Tidying low-level debug tool driver code:
- Use automatic objects for libusb/hidapi resources, where possible (to reduce manual resource management) - Removed unused/redundant code - Tidied HidInterface class - Tidied debug tool initialisation code - Other bits of tidying
This commit is contained in:
@@ -34,16 +34,12 @@ namespace Bloom::DebugToolDrivers
|
||||
static const std::uint16_t USB_VENDOR_ID = 1003;
|
||||
static const std::uint16_t USB_PRODUCT_ID = 8465;
|
||||
|
||||
XplainedPro(): UsbDevice(XplainedPro::USB_VENDOR_ID, XplainedPro::USB_PRODUCT_ID) {}
|
||||
XplainedPro();
|
||||
|
||||
void init() override;
|
||||
|
||||
void close() override;
|
||||
|
||||
Protocols::CmsisDap::Edbg::EdbgInterface& getEdbgInterface() {
|
||||
return this->edbgInterface;
|
||||
}
|
||||
|
||||
DebugToolDrivers::TargetInterfaces::TargetPowerManagementInterface* getTargetPowerManagementInterface() override {
|
||||
return this->targetPowerManagementInterface.get();
|
||||
}
|
||||
@@ -54,7 +50,7 @@ namespace Bloom::DebugToolDrivers
|
||||
|
||||
std::string getName() override {
|
||||
return "Xplained Pro";
|
||||
};
|
||||
}
|
||||
|
||||
/**
|
||||
* Retrieves the device serial number via the Discovery Protocol.
|
||||
@@ -74,7 +70,7 @@ namespace Bloom::DebugToolDrivers
|
||||
void endSession();
|
||||
|
||||
private:
|
||||
Protocols::CmsisDap::Edbg::EdbgInterface edbgInterface = Protocols::CmsisDap::Edbg::EdbgInterface();
|
||||
std::unique_ptr<Protocols::CmsisDap::Edbg::EdbgInterface> edbgInterface = nullptr;
|
||||
std::unique_ptr<Protocols::CmsisDap::Edbg::Avr::EdbgAvr8Interface> edbgAvr8Interface = nullptr;
|
||||
|
||||
std::unique_ptr<
|
||||
|
||||
Reference in New Issue
Block a user