The HexViewerWidget doesn't make any changes to memory regions - no need for them to be mutable

This commit is contained in:
Nav
2023-03-25 20:14:50 +00:00
parent 0f456310c8
commit 2fad19f533
6 changed files with 16 additions and 16 deletions

View File

@@ -20,8 +20,8 @@ namespace Bloom::Widgets
const TargetMemoryDescriptor& targetMemoryDescriptor,
const std::optional<Targets::TargetMemoryBuffer>& data,
HexViewerWidgetSettings& settings,
std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
const std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
const std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
QWidget* parent
)
: QWidget(parent)

View File

@@ -31,8 +31,8 @@ namespace Bloom::Widgets
const Targets::TargetMemoryDescriptor& targetMemoryDescriptor,
const std::optional<Targets::TargetMemoryBuffer>& data,
HexViewerWidgetSettings& settings,
std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
const std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
const std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
QWidget* parent
);
@@ -52,8 +52,8 @@ namespace Bloom::Widgets
const Targets::TargetMemoryDescriptor& targetMemoryDescriptor;
const std::optional<Targets::TargetMemoryBuffer>& data;
std::vector<FocusedMemoryRegion>& focusedMemoryRegions;
std::vector<ExcludedMemoryRegion>& excludedMemoryRegions;
const std::vector<FocusedMemoryRegion>& focusedMemoryRegions;
const std::vector<ExcludedMemoryRegion>& excludedMemoryRegions;
HexViewerWidgetSettings& settings;

View File

@@ -16,8 +16,8 @@ namespace Bloom::Widgets
ItemGraphicsScene::ItemGraphicsScene(
const Targets::TargetMemoryDescriptor& targetMemoryDescriptor,
const std::optional<Targets::TargetMemoryBuffer>& data,
std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
const std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
const std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
HexViewerWidgetSettings& settings,
QGraphicsView* parent
)

View File

@@ -45,8 +45,8 @@ namespace Bloom::Widgets
ItemGraphicsScene(
const Targets::TargetMemoryDescriptor& targetMemoryDescriptor,
const std::optional<Targets::TargetMemoryBuffer>& data,
std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
const std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
const std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
HexViewerWidgetSettings& settings,
QGraphicsView* parent
);
@@ -82,8 +82,8 @@ namespace Bloom::Widgets
HexViewerSharedState state;
std::vector<FocusedMemoryRegion>& focusedMemoryRegions;
std::vector<ExcludedMemoryRegion>& excludedMemoryRegions;
const std::vector<FocusedMemoryRegion>& focusedMemoryRegions;
const std::vector<ExcludedMemoryRegion>& excludedMemoryRegions;
std::unique_ptr<TopLevelGroupItem> topLevelGroup = nullptr;

View File

@@ -9,8 +9,8 @@ namespace Bloom::Widgets
ItemGraphicsView::ItemGraphicsView(
const TargetMemoryDescriptor& targetMemoryDescriptor,
const std::optional<Targets::TargetMemoryBuffer>& data,
std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
const std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
const std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
HexViewerWidgetSettings& settings,
QWidget* parent
)

View File

@@ -20,8 +20,8 @@ namespace Bloom::Widgets
ItemGraphicsView(
const Targets::TargetMemoryDescriptor& targetMemoryDescriptor,
const std::optional<Targets::TargetMemoryBuffer>& data,
std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
const std::vector<FocusedMemoryRegion>& focusedMemoryRegions,
const std::vector<ExcludedMemoryRegion>& excludedMemoryRegions,
HexViewerWidgetSettings& settings,
QWidget* parent
);