From 2fad19f53351e25043b1b2f269fbe908ba0a8b20 Mon Sep 17 00:00:00 2001 From: Nav Date: Sat, 25 Mar 2023 20:14:50 +0000 Subject: [PATCH] The HexViewerWidget doesn't make any changes to memory regions - no need for them to be mutable --- .../HexViewerWidget/HexViewerWidget.cpp | 4 ++-- .../HexViewerWidget/HexViewerWidget.hpp | 8 ++++---- .../HexViewerWidget/ItemGraphicsScene.cpp | 4 ++-- .../HexViewerWidget/ItemGraphicsScene.hpp | 8 ++++---- .../HexViewerWidget/ItemGraphicsView.cpp | 4 ++-- .../HexViewerWidget/ItemGraphicsView.hpp | 4 ++-- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/HexViewerWidget.cpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/HexViewerWidget.cpp index c22d43b1..8c43c2ac 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/HexViewerWidget.cpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/HexViewerWidget.cpp @@ -20,8 +20,8 @@ namespace Bloom::Widgets const TargetMemoryDescriptor& targetMemoryDescriptor, const std::optional& data, HexViewerWidgetSettings& settings, - std::vector& focusedMemoryRegions, - std::vector& excludedMemoryRegions, + const std::vector& focusedMemoryRegions, + const std::vector& excludedMemoryRegions, QWidget* parent ) : QWidget(parent) diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/HexViewerWidget.hpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/HexViewerWidget.hpp index 13c6b90c..8ba7ce49 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/HexViewerWidget.hpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/HexViewerWidget.hpp @@ -31,8 +31,8 @@ namespace Bloom::Widgets const Targets::TargetMemoryDescriptor& targetMemoryDescriptor, const std::optional& data, HexViewerWidgetSettings& settings, - std::vector& focusedMemoryRegions, - std::vector& excludedMemoryRegions, + const std::vector& focusedMemoryRegions, + const std::vector& excludedMemoryRegions, QWidget* parent ); @@ -52,8 +52,8 @@ namespace Bloom::Widgets const Targets::TargetMemoryDescriptor& targetMemoryDescriptor; const std::optional& data; - std::vector& focusedMemoryRegions; - std::vector& excludedMemoryRegions; + const std::vector& focusedMemoryRegions; + const std::vector& excludedMemoryRegions; HexViewerWidgetSettings& settings; diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.cpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.cpp index 8fe23c40..53a1a73b 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.cpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.cpp @@ -16,8 +16,8 @@ namespace Bloom::Widgets ItemGraphicsScene::ItemGraphicsScene( const Targets::TargetMemoryDescriptor& targetMemoryDescriptor, const std::optional& data, - std::vector& focusedMemoryRegions, - std::vector& excludedMemoryRegions, + const std::vector& focusedMemoryRegions, + const std::vector& excludedMemoryRegions, HexViewerWidgetSettings& settings, QGraphicsView* parent ) diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.hpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.hpp index 4538713a..62209d2a 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.hpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.hpp @@ -45,8 +45,8 @@ namespace Bloom::Widgets ItemGraphicsScene( const Targets::TargetMemoryDescriptor& targetMemoryDescriptor, const std::optional& data, - std::vector& focusedMemoryRegions, - std::vector& excludedMemoryRegions, + const std::vector& focusedMemoryRegions, + const std::vector& excludedMemoryRegions, HexViewerWidgetSettings& settings, QGraphicsView* parent ); @@ -82,8 +82,8 @@ namespace Bloom::Widgets HexViewerSharedState state; - std::vector& focusedMemoryRegions; - std::vector& excludedMemoryRegions; + const std::vector& focusedMemoryRegions; + const std::vector& excludedMemoryRegions; std::unique_ptr topLevelGroup = nullptr; diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.cpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.cpp index 0177d1fc..8a1e208a 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.cpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.cpp @@ -9,8 +9,8 @@ namespace Bloom::Widgets ItemGraphicsView::ItemGraphicsView( const TargetMemoryDescriptor& targetMemoryDescriptor, const std::optional& data, - std::vector& focusedMemoryRegions, - std::vector& excludedMemoryRegions, + const std::vector& focusedMemoryRegions, + const std::vector& excludedMemoryRegions, HexViewerWidgetSettings& settings, QWidget* parent ) diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.hpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.hpp index 62452651..aab009ac 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.hpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.hpp @@ -20,8 +20,8 @@ namespace Bloom::Widgets ItemGraphicsView( const Targets::TargetMemoryDescriptor& targetMemoryDescriptor, const std::optional& data, - std::vector& focusedMemoryRegions, - std::vector& excludedMemoryRegions, + const std::vector& focusedMemoryRegions, + const std::vector& excludedMemoryRegions, HexViewerWidgetSettings& settings, QWidget* parent );