doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tidying

Browse Source
This commit is contained in:
Nav
2024-08-17 12:44:01 +01:00
parent c662e946ca
commit 2f6238e360
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/DebugToolDrivers/Microchip/Protocols/EDBG/AVR/EdbgAvr8Interface.cpp
View File

@@ -327,6 +327,9 @@ namespace DebugToolDrivers::Microchip::Protocols::Edbg::Avr
* *
* So it appears we cannot use that command for UPDI sessions. For this reason, we will just read the * So it appears we cannot use that command for UPDI sessions. For this reason, we will just read the
* signature from memory via the signature memory segment. * signature from memory via the signature memory segment.
*
* TODO: We're assuming the signature memory segment will always reside in the `data` address space, for
* UPDI targets. Review.
*/ */
const auto signatureMemory = this->readMemory( const auto signatureMemory = this->readMemory(
Avr8MemoryType::SRAM, Avr8MemoryType::SRAM,

6
src/Targets/Microchip/AVR8/Avr8.cpp
View File

@@ -323,11 +323,7 @@ namespace Targets::Microchip::Avr8
); );
} }
/* // The debug interface may have its own access restrictions for registers.
* The debug interface may have its own access restrictions for registers.
*
* We must amend the register descriptors with the appropriate restrictions.
*/
for (auto& [peripheralKey, peripheral] : descriptor.peripheralDescriptorsByKey) { for (auto& [peripheralKey, peripheral] : descriptor.peripheralDescriptorsByKey) {
for (auto& [groupKey, registerGroup] : peripheral.registerGroupDescriptorsByKey) { for (auto& [groupKey, registerGroup] : peripheral.registerGroupDescriptorsByKey) {
this->applyDebugInterfaceRegisterAccessRestrictions( this->applyDebugInterfaceRegisterAccessRestrictions(