This commit is contained in:
Nav
2024-08-17 12:44:01 +01:00
parent c662e946ca
commit 2f6238e360
2 changed files with 4 additions and 5 deletions

View File

@@ -327,6 +327,9 @@ namespace DebugToolDrivers::Microchip::Protocols::Edbg::Avr
*
* So it appears we cannot use that command for UPDI sessions. For this reason, we will just read the
* signature from memory via the signature memory segment.
*
* TODO: We're assuming the signature memory segment will always reside in the `data` address space, for
* UPDI targets. Review.
*/
const auto signatureMemory = this->readMemory(
Avr8MemoryType::SRAM,

View File

@@ -323,11 +323,7 @@ namespace Targets::Microchip::Avr8
);
}
/*
* The debug interface may have its own access restrictions for registers.
*
* We must amend the register descriptors with the appropriate restrictions.
*/
// The debug interface may have its own access restrictions for registers.
for (auto& [peripheralKey, peripheral] : descriptor.peripheralDescriptorsByKey) {
for (auto& [groupKey, registerGroup] : peripheral.registerGroupDescriptorsByKey) {
this->applyDebugInterfaceRegisterAccessRestrictions(