Renamed GDB & TargetConrollerConsole read & write register functions/classes to a more generic name.

src/DebugServers/GdbRsp/CommandPackets/CommandPacketFactory.cpp

@@ -24,10 +24,10 @@ std::unique_ptr<CommandPacket> CommandPacketFactory::create(std::vector<unsigned
             return std::make_unique<CommandPackets::SupportedFeaturesQuery>(rawPacket);
 
         } else if (rawPacketString[1] == 'g' || rawPacketString[1] == 'p') {
-            return std::make_unique<CommandPackets::ReadGeneralRegisters>(rawPacket);
+            return std::make_unique<CommandPackets::ReadRegisters>(rawPacket);
 
         } else if (rawPacketString[1] == 'P') {
-            return std::make_unique<CommandPackets::WriteGeneralRegister>(rawPacket);
+            return std::make_unique<CommandPackets::WriteRegister>(rawPacket);
 
         } else if (rawPacketString[1] == 'c') {
             return std::make_unique<CommandPackets::ContinueExecution>(rawPacket);

src/DebugServers/GdbRsp/CommandPackets/CommandPacketFactory.hpp

@@ -7,8 +7,8 @@
 #include "CommandPacket.hpp"
 #include "InterruptExecution.hpp"
 #include "SupportedFeaturesQuery.hpp"
-#include "ReadGeneralRegisters.hpp"
-#include "WriteGeneralRegister.hpp"
+#include "ReadRegisters.hpp"
+#include "WriteRegister.hpp"
 #include "ReadMemory.hpp"
 #include "WriteMemory.hpp"
 #include "StepExecution.hpp"

src/DebugServers/GdbRsp/CommandPackets/ReadRegisters.cpp

@@ -1,15 +1,15 @@
-#include "ReadGeneralRegisters.hpp"
+#include "ReadRegisters.hpp"
 #include "src/DebugServers/GdbRsp/GdbRspDebugServer.hpp"
 
 using namespace Bloom::DebugServers::Gdb::CommandPackets;
 
-void ReadGeneralRegisters::init() {
+void ReadRegisters::init() {
     if (this->data.size() >= 2 && this->data.front() == 'p') {
         // This command packet is requesting a specific register
         this->registerNumber = static_cast<size_t>(std::stoi(std::string(this->data.begin() + 1, this->data.end())));
     }
 }
 
-void ReadGeneralRegisters::dispatchToHandler(Gdb::GdbRspDebugServer& gdbRspDebugServer) {
+void ReadRegisters::dispatchToHandler(Gdb::GdbRspDebugServer& gdbRspDebugServer) {
     gdbRspDebugServer.handleGdbPacket(*this);
 }

src/DebugServers/GdbRsp/CommandPackets/ReadRegisters.hpp

@@ -7,11 +7,11 @@
 namespace Bloom::DebugServers::Gdb::CommandPackets
 {
     /**
-     * The ReadGeneralRegisters class implements a structure for "g" and "p" command packets. In response to these
+     * The ReadRegisters class implements a structure for "g" and "p" command packets. In response to these
      * packets, the server is expected to send register values for all registers (for "g" packets) or for a single
      * register (for "p" packets).
      */
-    class ReadGeneralRegisters: public CommandPacket
+    class ReadRegisters: public CommandPacket
     {
     private:
         void init();
@@ -26,7 +26,7 @@ namespace Bloom::DebugServers::Gdb::CommandPackets
          */
         std::optional<int> registerNumber;
 
-        explicit ReadGeneralRegisters(const std::vector<unsigned char>& rawPacket): CommandPacket(rawPacket) {
+        explicit ReadRegisters(const std::vector<unsigned char>& rawPacket): CommandPacket(rawPacket) {
             init();
         };
 

src/DebugServers/GdbRsp/CommandPackets/WriteRegister.cpp

@@ -1,11 +1,11 @@
-#include "WriteGeneralRegister.hpp"
+#include "WriteRegister.hpp"
 #include "src/DebugServers/GdbRsp/GdbRspDebugServer.hpp"
 #include "src/Exceptions/Exception.hpp"
 
 using namespace Bloom::DebugServers::Gdb::CommandPackets;
 using namespace Bloom::Exceptions;
 
-void WriteGeneralRegister::init() {
+void WriteRegister::init() {
     // The P packet updates a single register
     auto packet = std::string(this->data.begin(), this->data.end());
 
@@ -23,6 +23,6 @@ void WriteGeneralRegister::init() {
     std::reverse(this->registerValue.begin(), this->registerValue.end());
 }
 
-void WriteGeneralRegister::dispatchToHandler(Gdb::GdbRspDebugServer& gdbRspDebugServer) {
+void WriteRegister::dispatchToHandler(Gdb::GdbRspDebugServer& gdbRspDebugServer) {
     gdbRspDebugServer.handleGdbPacket(*this);
 }

src/DebugServers/GdbRsp/CommandPackets/WriteRegister.hpp

@@ -8,10 +8,10 @@
 namespace Bloom::DebugServers::Gdb::CommandPackets
 {
     /**
-     * The WriteGeneralRegisters class implements the structure for "P" packets. Upon receiving this packet,
+     * The WriteRegisters class implements the structure for "P" packets. Upon receiving this packet,
      * server is expected to update a register value to the target.
      */
-    class WriteGeneralRegister: public CommandPacket
+    class WriteRegister: public CommandPacket
     {
     private:
         void init();
@@ -20,7 +20,7 @@ namespace Bloom::DebugServers::Gdb::CommandPackets
         int registerNumber = 0;
         std::vector<unsigned char> registerValue;
 
-        explicit WriteGeneralRegister(const std::vector<unsigned char>& rawPacket): CommandPacket(rawPacket) {
+        explicit WriteRegister(const std::vector<unsigned char>& rawPacket): CommandPacket(rawPacket) {
             init();
         };