Replaced nasty onInsightStateChangedEvent event handler in TargetController with new GetTargetState command

src/Insight/UserInterfaces/InsightWindow/InsightWindow.cpp

@@ -347,6 +347,7 @@ namespace Bloom
 
         this->setUiDisabled(this->targetState != TargetState::STOPPED);
         this->activated = true;
+        emit this->activatedSignal();
     }
 
     void InsightWindow::populateVariantMenu() {

src/Insight/UserInterfaces/InsightWindow/InsightWindow.hpp

@@ -50,6 +50,9 @@ namespace Bloom
 
         void init(Targets::TargetDescriptor targetDescriptor);
 
+    signals:
+        void activatedSignal();
+
     protected:
         void resizeEvent(QResizeEvent* event) override;
         void showEvent(QShowEvent* event) override;

src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/TargetMemoryInspectionPane.cpp

@@ -243,6 +243,10 @@ void TargetMemoryInspectionPane::sanitiseSettings() {
 }
 
 void TargetMemoryInspectionPane::onTargetStateChanged(Targets::TargetState newState) {
+    if (this->targetState == newState) {
+        return;
+    }
+
     using Targets::TargetState;
     this->targetState = newState;
 

src/Insight/UserInterfaces/InsightWindow/Widgets/TargetRegisterInspector/TargetRegisterInspectorWindow.cpp

@@ -261,6 +261,10 @@ namespace Bloom::Widgets
     }
 
     void TargetRegisterInspectorWindow::onTargetStateChanged(TargetState newState) {
+        if (this->targetState == newState) {
+            return;
+        }
+
         if (newState != TargetState::STOPPED) {
             this->registerValueTextInput->setDisabled(true);
             this->registerValueBitsetWidgetContainer->setDisabled(true);

src/Insight/UserInterfaces/InsightWindow/Widgets/TargetRegistersPane/TargetRegistersPaneWidget.cpp

@@ -231,6 +231,10 @@ namespace Bloom::Widgets
     }
 
     void TargetRegistersPaneWidget::onTargetStateChanged(Targets::TargetState newState) {
+        if (this->targetState == newState) {
+            return;
+        }
+
         using Targets::TargetState;
         this->targetState = newState;
 

src/Insight/UserInterfaces/InsightWindow/Widgets/TargetWidgets/TargetPackageWidget.cpp

@@ -63,6 +63,10 @@ namespace Bloom::Widgets::InsightTargetWidgets
     }
 
     void TargetPackageWidget::onTargetStateChanged(TargetState newState) {
+        if (this->targetState == newState) {
+            return;
+        }
+
         this->targetState = newState;
 
         if (newState == TargetState::RUNNING) {