doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed target stop event delay in Insight - it wasn't working very well and I don't think many users even use conditional breakpoints for other reasons.

Browse Source
This commit is contained in:
Nav
2022-08-30 20:27:27 +01:00
parent 99db00c0cc
commit f113fca8ac
1 changed files with 3 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/Insight/InsightWorker/InsightWorker.cpp
View File

@@ -90,39 +90,10 @@ namespace Bloom
return; return;
} }
/*
* When we report a target halt to Insight, Insight will immediately seek more data from the target (such as
* GPIO pin states). This can be problematic for cases where the target had halted due to a conditional
* breakpoint.
*
* For conditional breakpoints, a software breakpoint is employed to halt target execution and give the debug
* client an opportunity to check the condition. In cases where the condition is not met, the client will
* immediately request for execution to be resumed. It's important that Insight does not get in the way of this
* process, as it could end up slowing things down significantly.
*
* For the above reason, we don't want to report any target halts to Insight, unless we can be sure that the
* client isn't going to immediately resume execution upon checking the condition.
*
* We do this by providing a time window for the TargetExecutionResumed event. If the event is triggered within
* that time window, we won't report the target halt to Insight, thus preventing Insight from needlessly
* seeking data from the target and slowing things down.
*
* This isn't the best approach, TBH, as it introduces a delay to Insight's response to the target halting. The
* problem is, we cannot differentiate a conditional breakpoint with a software breakpoint, so this seems to be
* the only way. It would be nice if the debug client gave us some form of indication of whether the breakpoint
* is a conditional one.
*/
auto resumedEvent = this->eventListener->waitForEvent<Events::TargetExecutionResumed>(
std::chrono::milliseconds(650)
);
if (!resumedEvent.has_value()) {
Logger::debug("Accepted TargetExecutionStopped event");
this->lastTargetState = TargetState::STOPPED; this->lastTargetState = TargetState::STOPPED;
emit this->targetStateUpdated(TargetState::STOPPED); emit this->targetStateUpdated(TargetState::STOPPED);
emit this->targetProgramCounterUpdated(event.programCounter); emit this->targetProgramCounterUpdated(event.programCounter);
} }
}
void InsightWorker::onTargetResumedEvent(const Events::TargetExecutionResumed& event) { void InsightWorker::onTargetResumedEvent(const Events::TargetExecutionResumed& event) {
if (this->lastTargetState != TargetState::RUNNING) { if (this->lastTargetState != TargetState::RUNNING) {