From e7b270a30ccbd494c09172a455db8b8af6775e23 Mon Sep 17 00:00:00 2001 From: Nav Date: Sun, 27 Oct 2024 00:26:41 +0100 Subject: [PATCH] Corrected bug in GDB server config (IP address param wasn't being validated properly) --- src/DebugServer/Gdb/GdbDebugServerConfig.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/DebugServer/Gdb/GdbDebugServerConfig.cpp b/src/DebugServer/Gdb/GdbDebugServerConfig.cpp index 2c7bc446..bd1d65ac 100644 --- a/src/DebugServer/Gdb/GdbDebugServerConfig.cpp +++ b/src/DebugServer/Gdb/GdbDebugServerConfig.cpp @@ -9,14 +9,15 @@ namespace DebugServer::Gdb : DebugServerConfig(debugServerConfig) { if (debugServerConfig.debugServerNode["ipAddress"]) { - if (!YamlUtilities::isCastable(debugServerConfig.debugServerNode["ipAddress"])) { + if (YamlUtilities::isCastable(debugServerConfig.debugServerNode["ipAddress"])) { + this->listeningAddress = debugServerConfig.debugServerNode["ipAddress"].as(); + + } else { Logger::error( "Invalid GDB debug server config parameter ('ipAddress') provided - must be a string. The " "parameter will be ignored." ); } - - this->listeningAddress = debugServerConfig.debugServerNode["ipAddress"].as(); } if (debugServerConfig.debugServerNode["port"]) {