Tidying

src/DebugToolDrivers/USB/HID/HidInterface.cpp

@@ -14,7 +14,7 @@ void HidInterface::init() {
     }
 
     hid_init();
-    hid_device* hidDevice;
+    hid_device* hidDevice = nullptr;
 
     std::string hidInterfacePath = this->getDevicePathByInterfaceNumber(this->getNumber());
     Logger::debug("HID device path: " + hidInterfacePath);
@@ -36,7 +36,7 @@ void HidInterface::init() {
 }
 
 void HidInterface::close() {
-    auto hidDevice = this->getHidDevice();
+    auto* hidDevice = this->getHidDevice();
 
     if (hidDevice != nullptr) {
         this->libUsbDeviceHandle = nullptr;
@@ -74,8 +74,9 @@ void HidInterface::write(std::vector<unsigned char> buffer) {
         throw DeviceCommunicationFailure(
             "Cannot send data via HID interface - data exceeds maximum packet size."
         );
+    }
 
-    } else if (buffer.size() < this->getInputReportSize()) {
+    if (buffer.size() < this->getInputReportSize()) {
         /*
          * Every report we send via the USB HID interface should be of a fixed size.
          * In the event of a report being too small, we just fill the buffer vector with 0.
@@ -83,7 +84,7 @@ void HidInterface::write(std::vector<unsigned char> buffer) {
         buffer.resize(this->getInputReportSize(), 0);
     }
 
-    int transferred;
+    int transferred = 0;
     auto length = buffer.size();
 
     if ((transferred = hid_write(this->getHidDevice(), buffer.data(), length)) != length) {

src/DebugToolDrivers/USB/Interface.hpp

@@ -15,6 +15,14 @@ namespace Bloom::Usb
             this->setNumber(interfaceNumber);
         }
 
+        virtual ~Interface() = default;
+
+        Interface(const Interface& other) = default;
+        Interface(Interface&& other) = default;
+
+        Interface& operator = (const Interface& other) = default;
+        Interface& operator = (Interface&& other) = default;
+
         void setLibUsbDevice(libusb_device* libUsbDevice) {
             this->libUsbDevice = libUsbDevice;
         }

src/DebugToolDrivers/USB/UsbDevice.hpp

@@ -14,7 +14,14 @@ namespace Bloom::Usb
     {
     public:
         UsbDevice(std::uint16_t vendorId, std::uint16_t productId): vendorId(vendorId), productId(productId) {};
-        ~UsbDevice() = default;
+
+        virtual ~UsbDevice() = default;
+
+        UsbDevice(const UsbDevice& other) = default;
+        UsbDevice(UsbDevice&& other) = default;
+
+        UsbDevice& operator = (const UsbDevice& other) = default;
+        UsbDevice& operator = (UsbDevice&& other) = default;
 
         void init();