General tidying, addressing issues found by static analysis tool.

2021-06-22 23:52:31 +01:00
parent 69cee4d579
commit d365f6348b
151 changed files with 386 additions and 420 deletions
--- a/src/DebugToolDrivers/Protocols/CMSIS-DAP/Response.hpp
+++ b/src/DebugToolDrivers/Protocols/CMSIS-DAP/Response.hpp
@@ -24,11 +24,11 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap
        Response() = default;
        virtual void init(const std::vector<unsigned char>& rawResponse);

-        unsigned char getResponseId() const {
+        [[nodiscard]] unsigned char getResponseId() const {
            return this->responseId;
        }

-        virtual const std::vector<unsigned char>& getData() const {
+        [[nodiscard]] virtual const std::vector<unsigned char>& getData() const {
            return this->data;
        }