doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

General tidying, addressing issues found by static analysis tool.

Browse Source
This commit is contained in:
Nav
2021-06-22 23:52:31 +01:00
parent 69cee4d579
commit d365f6348b
151 changed files with 386 additions and 420 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/DebugServers/GdbRsp/Packet.hpp
View File

@@ -28,11 +28,11 @@ namespace Bloom::DebugServers::Gdb
}
public:
Packet() = default;
Packet(const std::vector<unsigned char>& rawPacket) {
explicit Packet(const std::vector<unsigned char>& rawPacket) {
this->init(rawPacket);
}
virtual std::vector<unsigned char> getData() const {
[[nodiscard]] virtual std::vector<unsigned char> getData() const {
return this->data;
}
@@ -45,7 +45,7 @@ namespace Bloom::DebugServers::Gdb
*
* @return
*/
std::vector<unsigned char> toRawPacket() const {
[[nodiscard]] std::vector<unsigned char> toRawPacket() const {
std::vector<unsigned char> packet = {'$'};
auto data = this->getData();
@@ -90,7 +90,7 @@ namespace Bloom::DebugServers::Gdb
* @param data
* @return
*/
static std::string dataToHex(std::vector<unsigned char> data) {
static std::string dataToHex(const std::vector<unsigned char>& data) {
std::stringstream stream;
stream << std::hex << std::setfill('0');