doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Applied debug-interface-specific access restrictions for memory and registers

Browse Source
This commit is contained in:
Nav
2024-12-07 16:43:16 +00:00
parent 289919f330
commit cbfbd9f4b8
11 changed files with 78 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/DebugToolDrivers/Microchip/Protocols/EDBG/AVR/EdbgAvr8Interface.cpp
View File

@@ -270,8 +270,8 @@ namespace DebugToolDrivers::Microchip::Protocols::Edbg::Avr
}
}
Targets::TargetRegisterAccess EdbgAvr8Interface::getRegisterAccess(
const TargetRegisterDescriptor& registerDescriptor,
void EdbgAvr8Interface::applyAccessRestrictions(
TargetRegisterDescriptor& registerDescriptor,
const TargetAddressSpaceDescriptor& addressSpaceDescriptor
) {
/*
@@ -281,10 +281,10 @@ namespace DebugToolDrivers::Microchip::Protocols::Edbg::Avr
* There are some other memory types we can use to access some other registers during a debug session, but
* these are yet to be implemented.
*/
const auto access = addressSpaceDescriptor.key == this->session.dataAddressSpace.key
const auto accessible = addressSpaceDescriptor.key == this->session.dataAddressSpace.key
|| addressSpaceDescriptor.key == this->session.registerFileAddressSpace.key;
return {access, access};
registerDescriptor.access.readable = accessible && registerDescriptor.access.readable;
registerDescriptor.access.writable = accessible && registerDescriptor.access.writable;
}
TargetMemoryAddress EdbgAvr8Interface::getProgramCounter() {

4
src/DebugToolDrivers/Microchip/Protocols/EDBG/AVR/EdbgAvr8Interface.hpp
View File

@@ -138,8 +138,8 @@ namespace DebugToolDrivers::Microchip::Protocols::Edbg::Avr
*/
void deactivate() override;
Targets::TargetRegisterAccess getRegisterAccess(
const Targets::TargetRegisterDescriptor& registerDescriptor,
void applyAccessRestrictions(
Targets::TargetRegisterDescriptor& registerDescriptor,
const Targets::TargetAddressSpaceDescriptor& addressSpaceDescriptor
) override;