Tidying

src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp

@@ -1118,12 +1118,12 @@ void EdbgAvr8Interface::activatePhysical(bool applyExternalReset) {
     if (response.getResponseId() == Avr8ResponseId::FAILED) {
         if (!applyExternalReset) {
             // Try again with external reset applied
-            Logger::debug("Failed to activate physical interface on AVR8 target - retrying with external reset applied.");
+            Logger::debug("Failed to activate physical interface on AVR8 target "
+                "- retrying with external reset applied.");
             return this->activatePhysical(true);
-
-        } else {
-            throw Avr8CommandFailure("AVR8 Activate physical interface command failed", response);
         }
+
+        throw Avr8CommandFailure("AVR8 Activate physical interface command failed", response);
     }
 
     this->physicalInterfaceActivated = true;

src/EventManager/Events/BreakpointRemovedOnTarget.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class BreakpointRemovedOnTarget: public Event
     {
     public:
-        static inline EventType type = EventType::BREAKPOINT_REMOVED_ON_TARGET;
+        static constexpr EventType type = EventType::BREAKPOINT_REMOVED_ON_TARGET;
         static inline const std::string name = "BreakpointRemovedOnTarget";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/BreakpointSetOnTarget.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class BreakpointSetOnTarget: public Event
     {
     public:
-        static inline EventType type = EventType::BREAKPOINT_SET_ON_TARGET;
+        static constexpr EventType type = EventType::BREAKPOINT_SET_ON_TARGET;
         static inline const std::string name = "BreakpointSetOnTarget";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/DebugServerThreadStateChanged.hpp

@@ -10,7 +10,7 @@ namespace Bloom::Events
     class DebugServerThreadStateChanged: public Event
     {
     public:
-        static inline EventType type = EventType::DEBUG_SERVER_THREAD_STATE_CHANGED;
+        static constexpr EventType type = EventType::DEBUG_SERVER_THREAD_STATE_CHANGED;
         static inline const std::string name = "DebugServerThreadStateChanged";
 
         explicit DebugServerThreadStateChanged(ThreadState state): state(state) {};

src/EventManager/Events/DebugSessionFinished.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class DebugSessionFinished: public Event
     {
     public:
-        static inline EventType type = EventType::DEBUG_SESSION_FINISHED;
+        static constexpr EventType type = EventType::DEBUG_SESSION_FINISHED;
         static inline const std::string name = "DebugSessionFinished";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/DebugSessionStarted.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class DebugSessionStarted: public Event
     {
     public:
-        static inline EventType type = EventType::DEBUG_SESSION_STARTED;
+        static constexpr EventType type = EventType::DEBUG_SESSION_STARTED;
         static inline const std::string name = "DebugSessionStarted";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/Event.hpp

@@ -62,7 +62,7 @@ namespace Bloom::Events
         QDateTime createdTimestamp = DateTime::currentDateTime();
         std::optional<int> correlationId;
 
-        static inline EventType type = EventType::GENERIC;
+        static constexpr EventType type = EventType::GENERIC;
         static inline const std::string name = "GenericEvent";
 
         [[nodiscard]] virtual std::string getName() const {

src/EventManager/Events/ExtractTargetDescriptor.hpp

@@ -13,7 +13,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = TargetDescriptorExtracted;
 
-        static inline EventType type = EventType::EXTRACT_TARGET_DESCRIPTOR;
+        static constexpr EventType type = EventType::EXTRACT_TARGET_DESCRIPTOR;
         static inline const std::string name = "ExtractTargetDescriptor";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/InsightThreadStateChanged.hpp

@@ -12,7 +12,7 @@ namespace Bloom::Events
     public:
         explicit InsightThreadStateChanged(ThreadState state): state(state) {};
 
-        static inline EventType type = EventType::INSIGHT_THREAD_STATE_CHANGED;
+        static constexpr EventType type = EventType::INSIGHT_THREAD_STATE_CHANGED;
         static inline const std::string name = "InsightThreadStateChanged";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/MemoryRetrievedFromTarget.hpp

@@ -10,7 +10,7 @@ namespace Bloom::Events
     class MemoryRetrievedFromTarget: public Event
     {
     public:
-        static inline EventType type = EventType::MEMORY_RETRIEVED_FROM_TARGET;
+        static constexpr EventType type = EventType::MEMORY_RETRIEVED_FROM_TARGET;
         static inline const std::string name = "MemoryRetrievedFromTarget";
         Targets::TargetMemoryBuffer data;
 

src/EventManager/Events/MemoryWrittenToTarget.hpp

@@ -10,7 +10,7 @@ namespace Bloom::Events
     class MemoryWrittenToTarget: public Event
     {
     public:
-        static inline EventType type = EventType::MEMORY_WRITTEN_TO_TARGET;
+        static constexpr EventType type = EventType::MEMORY_WRITTEN_TO_TARGET;
         static inline const std::string name = "MemoryWrittenToTarget";
 
         MemoryWrittenToTarget() = default;

src/EventManager/Events/ProgramCounterSetOnTarget.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class ProgramCounterSetOnTarget: public Event
     {
     public:
-        static inline EventType type = EventType::PROGRAM_COUNTER_SET_ON_TARGET;
+        static constexpr EventType type = EventType::PROGRAM_COUNTER_SET_ON_TARGET;
         static inline const std::string name = "ProgramCounterSetOnTarget";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/RegistersRetrievedFromTarget.hpp

@@ -10,7 +10,7 @@ namespace Bloom::Events
     class RegistersRetrievedFromTarget: public Event
     {
     public:
-        static inline EventType type = EventType::REGISTERS_RETRIEVED_FROM_TARGET;
+        static constexpr EventType type = EventType::REGISTERS_RETRIEVED_FROM_TARGET;
         static inline const std::string name = "RegistersRetrievedFromTarget";
         Targets::TargetRegisters registers;
 

src/EventManager/Events/RegistersWrittenToTarget.hpp

@@ -10,7 +10,7 @@ namespace Bloom::Events
     class RegistersWrittenToTarget: public Event
     {
     public:
-        static inline EventType type = EventType::REGISTERS_WRITTEN_TO_TARGET;
+        static constexpr EventType type = EventType::REGISTERS_WRITTEN_TO_TARGET;
         static inline const std::string name = "RegistersWrittenToTarget";
 
         Targets::TargetRegisters registers;

src/EventManager/Events/RemoveBreakpointOnTarget.hpp

@@ -14,7 +14,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = BreakpointRemovedOnTarget;
 
-        static inline EventType type = EventType::REMOVE_BREAKPOINT_ON_TARGET;
+        static constexpr EventType type = EventType::REMOVE_BREAKPOINT_ON_TARGET;
         static inline const std::string name = "RemoveBreakpointOnTarget";
         Targets::TargetBreakpoint breakpoint;
 

src/EventManager/Events/ReportTargetControllerState.hpp

@@ -12,7 +12,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = TargetControllerStateReported;
 
-        static inline EventType type = EventType::REPORT_TARGET_CONTROLLER_STATE;
+        static constexpr EventType type = EventType::REPORT_TARGET_CONTROLLER_STATE;
         static inline const std::string name = "ReportTargetControllerState";
 
         ReportTargetControllerState() {};

src/EventManager/Events/ResetTarget.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class ResetTarget: public Event
     {
     public:
-        static inline EventType type = EventType::RESET_TARGET;
+        static constexpr EventType type = EventType::RESET_TARGET;
         static inline const std::string name = "ResetTargetEvent";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/ResumeTargetExecution.hpp

@@ -13,7 +13,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = TargetExecutionResumed;
 
-        static inline EventType type = EventType::RESUME_TARGET_EXECUTION;
+        static constexpr EventType type = EventType::RESUME_TARGET_EXECUTION;
         static inline const std::string name = "ResumeTargetExecutionEvent";
         std::optional<std::uint32_t> fromProgramCounter;
 

src/EventManager/Events/RetrieveMemoryFromTarget.hpp

@@ -14,7 +14,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = MemoryRetrievedFromTarget;
 
-        static inline EventType type = EventType::RETRIEVE_MEMORY_FROM_TARGET;
+        static constexpr EventType type = EventType::RETRIEVE_MEMORY_FROM_TARGET;
         static inline const std::string name = "RetrieveMemoryFromTarget";
         Targets::TargetMemoryType memoryType = Targets::TargetMemoryType::RAM;
         std::uint32_t startAddress = 0;

src/EventManager/Events/RetrieveRegistersFromTarget.hpp

@@ -13,7 +13,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = RegistersRetrievedFromTarget;
 
-        static inline EventType type = EventType::RETRIEVE_REGISTERS_FROM_TARGET;
+        static constexpr EventType type = EventType::RETRIEVE_REGISTERS_FROM_TARGET;
         static inline const std::string name = "RetrieveRegistersFromTarget";
         Targets::TargetRegisterDescriptors descriptors;
 

src/EventManager/Events/RetrieveStackPointerFromTarget.hpp

@@ -12,7 +12,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = StackPointerRetrievedFromTarget;
 
-        static inline EventType type = EventType::RETRIEVE_STACK_POINTER_FROM_TARGET;
+        static constexpr EventType type = EventType::RETRIEVE_STACK_POINTER_FROM_TARGET;
         static inline const std::string name = "RetrieveStackPointerFromTarget";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/RetrieveTargetPinStates.hpp

@@ -12,7 +12,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = TargetPinStatesRetrieved;
 
-        static inline EventType type = EventType::RETRIEVE_TARGET_PIN_STATES;
+        static constexpr EventType type = EventType::RETRIEVE_TARGET_PIN_STATES;
         static inline const std::string name = "RetrieveTargetPinStates";
         int variantId = 0;
 

src/EventManager/Events/SetBreakpointOnTarget.hpp

@@ -14,7 +14,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = BreakpointSetOnTarget;
 
-        static inline EventType type = EventType::SET_BREAKPOINT_ON_TARGET;
+        static constexpr EventType type = EventType::SET_BREAKPOINT_ON_TARGET;
         static inline const std::string name = "SetBreakpointOnTarget";
         Targets::TargetBreakpoint breakpoint;
 

src/EventManager/Events/SetProgramCounterOnTarget.hpp

@@ -13,7 +13,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = ProgramCounterSetOnTarget;
 
-        static inline EventType type = EventType::SET_PROGRAM_COUNTER_ON_TARGET;
+        static constexpr EventType type = EventType::SET_PROGRAM_COUNTER_ON_TARGET;
         static inline const std::string name = "SetProgramCounterOnTarget";
         std::uint32_t address = 0;
 

src/EventManager/Events/SetTargetPinState.hpp

@@ -13,7 +13,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = TargetPinStatesRetrieved;
 
-        static inline EventType type = EventType::SET_TARGET_PIN_STATE;
+        static constexpr EventType type = EventType::SET_TARGET_PIN_STATE;
         static inline const std::string name = "SetTargetPinState";
         Targets::TargetPinDescriptor pinDescriptor;
         Targets::TargetPinState pinState;

src/EventManager/Events/ShutdownApplication.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class ShutdownApplication: public Event
     {
     public:
-        static inline EventType type = EventType::SHUTDOWN_APPLICATION;
+        static constexpr EventType type = EventType::SHUTDOWN_APPLICATION;
         static inline const std::string name = "ShutdownApplicationEvent";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/ShutdownDebugServer.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class ShutdownDebugServer: public Event
     {
     public:
-        static inline EventType type = EventType::SHUTDOWN_DEBUG_SERVER;
+        static constexpr EventType type = EventType::SHUTDOWN_DEBUG_SERVER;
         static inline const std::string name = "ShutdownDebugServer";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/ShutdownTargetController.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class ShutdownTargetController: public Event
     {
     public:
-        static inline EventType type = EventType::SHUTDOWN_TARGET_CONTROLLER;
+        static constexpr EventType type = EventType::SHUTDOWN_TARGET_CONTROLLER;
         static inline const std::string name = "ShutdownTargetControllerEvent";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/StackPointerRetrievedFromTarget.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class StackPointerRetrievedFromTarget: public Event
     {
     public:
-        static inline EventType type = EventType::STACK_POINTER_RETRIEVED_FROM_TARGET;
+        static constexpr EventType type = EventType::STACK_POINTER_RETRIEVED_FROM_TARGET;
         static inline const std::string name = "StackPointerRetrievedFromTarget";
         std::uint32_t stackPointer = 0;
 

src/EventManager/Events/StepTargetExecution.hpp

@@ -13,7 +13,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = TargetExecutionResumed;
 
-        static inline EventType type = EventType::STEP_TARGET_EXECUTION;
+        static constexpr EventType type = EventType::STEP_TARGET_EXECUTION;
         static inline const std::string name = "StepTargetExecution";
         std::optional<std::uint32_t> fromProgramCounter;
 

src/EventManager/Events/StopTargetExecution.hpp

@@ -12,7 +12,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = TargetExecutionStopped;
 
-        static inline EventType type = EventType::STOP_TARGET_EXECUTION;
+        static constexpr EventType type = EventType::STOP_TARGET_EXECUTION;
         static inline const std::string name = "StopTargetExecution";
 
         [[nodiscard]] EventType getType() const override {

src/EventManager/Events/TargetControllerErrorOccurred.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class TargetControllerErrorOccurred: public Event
     {
     public:
-        static inline EventType type = EventType::TARGET_CONTROLLER_ERROR_OCCURRED;
+        static constexpr EventType type = EventType::TARGET_CONTROLLER_ERROR_OCCURRED;
         static inline const std::string name = "TargetControllerErrorOccurred";
 
         std::string errorMessage;

src/EventManager/Events/TargetControllerStateReported.hpp

@@ -10,7 +10,7 @@ namespace Bloom::Events
     class TargetControllerStateReported: public Event
     {
     public:
-        static inline EventType type = EventType::TARGET_CONTROLLER_STATE_REPORTED;
+        static constexpr EventType type = EventType::TARGET_CONTROLLER_STATE_REPORTED;
         static inline const std::string name = "TargetControllerStateReported";
 
         TargetControllerState state;

src/EventManager/Events/TargetControllerThreadStateChanged.hpp

@@ -10,7 +10,7 @@ namespace Bloom::Events
     class TargetControllerThreadStateChanged: public Event
     {
     public:
-        static inline EventType type = EventType::TARGET_CONTROLLER_THREAD_STATE_CHANGED;
+        static constexpr EventType type = EventType::TARGET_CONTROLLER_THREAD_STATE_CHANGED;
         static inline const std::string name = "TargetControllerThreadStateChanged";
 
         explicit TargetControllerThreadStateChanged(ThreadState state): state(state) {};

src/EventManager/Events/TargetDescriptorExtracted.hpp

@@ -10,7 +10,7 @@ namespace Bloom::Events
     class TargetDescriptorExtracted: public Event
     {
     public:
-        static inline EventType type = EventType::TARGET_DESCRIPTOR_EXTRACTED;
+        static constexpr EventType type = EventType::TARGET_DESCRIPTOR_EXTRACTED;
         static inline const std::string name = "TargetDescriptorExtracted";
         Targets::TargetDescriptor targetDescriptor;
 

src/EventManager/Events/TargetExecutionResumed.hpp

@@ -9,7 +9,7 @@ namespace Bloom::Events
     class TargetExecutionResumed: public Event
     {
     public:
-        static inline EventType type = EventType::TARGET_EXECUTION_RESUMED;
+        static constexpr EventType type = EventType::TARGET_EXECUTION_RESUMED;
         static inline const std::string name = "TargetExecutionResumed";
 
         TargetExecutionResumed() = default;

src/EventManager/Events/TargetExecutionStopped.hpp

@@ -11,7 +11,7 @@ namespace Bloom::Events
     class TargetExecutionStopped: public Event
     {
     public:
-        static inline EventType type = EventType::TARGET_EXECUTION_STOPPED;
+        static constexpr EventType type = EventType::TARGET_EXECUTION_STOPPED;
         static inline const std::string name = "TargetExecutionStopped";
         std::uint32_t programCounter;
         Targets::TargetBreakCause breakCause;

src/EventManager/Events/TargetPinStatesRetrieved.hpp

@@ -11,7 +11,7 @@ namespace Bloom::Events
     class TargetPinStatesRetrieved: public Event
     {
     public:
-        static inline EventType type = EventType::TARGET_PIN_STATES_RETRIEVED;
+        static constexpr EventType type = EventType::TARGET_PIN_STATES_RETRIEVED;
         static inline const std::string name = "TargetPinStatesRetrieved";
         int variantId = 0;
         std::map<int, Targets::TargetPinState> pinSatesByNumber;

src/EventManager/Events/WriteMemoryToTarget.hpp

@@ -15,7 +15,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = MemoryWrittenToTarget;
 
-        static inline EventType type = EventType::WRITE_MEMORY_TO_TARGET;
+        static constexpr EventType type = EventType::WRITE_MEMORY_TO_TARGET;
         static inline const std::string name = "WriteMemoryToTarget";
         Targets::TargetMemoryType memoryType = Targets::TargetMemoryType::RAM;
         std::uint32_t startAddress = 0;

src/EventManager/Events/WriteRegistersToTarget.hpp

@@ -14,7 +14,7 @@ namespace Bloom::Events
     public:
         using TargetControllerResponseType = RegistersWrittenToTarget;
 
-        static inline EventType type = EventType::WRITE_REGISTERS_TO_TARGET;
+        static constexpr EventType type = EventType::WRITE_REGISTERS_TO_TARGET;
         static inline const std::string name = "WriteRegistersToTarget";
         Targets::TargetRegisters registers;
 

src/Insight/InsightWorker/Tasks/InsightWorkerTask.hpp

@@ -20,7 +20,7 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        InsightWorkerTaskState state;
+        InsightWorkerTaskState state = InsightWorkerTaskState::CREATED;
 
         InsightWorkerTask(): QObject(nullptr) {};
 

src/Targets/Microchip/AVR/AVR8/Avr8.cpp

@@ -203,7 +203,7 @@ TargetRegisters Avr8::readRegisters(TargetRegisterDescriptors descriptors) {
     TargetRegisters registers;
 
     for (auto registerDescriptorIt = descriptors.begin(); registerDescriptorIt != descriptors.end();) {
-        auto& descriptor = *registerDescriptorIt;
+        const auto& descriptor = *registerDescriptorIt;
 
         if (descriptor.type == TargetRegisterType::PROGRAM_COUNTER) {
             registers.push_back(this->getProgramCounterRegister());