From b3af06654ca0b0564890e83c15f6b063c474fee8 Mon Sep 17 00:00:00 2001 From: Nav Date: Sat, 4 Jun 2022 15:20:37 +0100 Subject: [PATCH] Tidying --- src/DebugServer/Gdb/CommandPackets/TargetInfoMachine.cpp | 3 --- .../CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp | 2 +- src/Targets/Microchip/AVR/AVR8/PhysicalInterface.hpp | 4 +++- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/DebugServer/Gdb/CommandPackets/TargetInfoMachine.cpp b/src/DebugServer/Gdb/CommandPackets/TargetInfoMachine.cpp index 29772e9c..28dfb7b5 100644 --- a/src/DebugServer/Gdb/CommandPackets/TargetInfoMachine.cpp +++ b/src/DebugServer/Gdb/CommandPackets/TargetInfoMachine.cpp @@ -9,7 +9,6 @@ #include "src/Application.hpp" #include "src/Logger/Logger.hpp" -#include "src/Exceptions/Exception.hpp" namespace Bloom::DebugServer::Gdb::CommandPackets { @@ -17,8 +16,6 @@ namespace Bloom::DebugServer::Gdb::CommandPackets using ResponsePackets::ResponsePacket; - using Exceptions::Exception; - TargetInfoMachine::TargetInfoMachine(Monitor&& monitorPacket) : Monitor(std::move(monitorPacket)) {} diff --git a/src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp b/src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp index 3ee96f91..b349a82c 100644 --- a/src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp +++ b/src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp @@ -1785,7 +1785,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr } void EdbgAvr8Interface::refreshTargetState() { - auto avrEvent = this->getAvrEvent(); + const auto avrEvent = this->getAvrEvent(); if (avrEvent != nullptr && avrEvent->getEventId() == AvrEventId::AVR8_BREAK_EVENT) { auto* breakEvent = dynamic_cast(avrEvent.get()); diff --git a/src/Targets/Microchip/AVR/AVR8/PhysicalInterface.hpp b/src/Targets/Microchip/AVR/AVR8/PhysicalInterface.hpp index 3b769991..2046ad0a 100644 --- a/src/Targets/Microchip/AVR/AVR8/PhysicalInterface.hpp +++ b/src/Targets/Microchip/AVR/AVR8/PhysicalInterface.hpp @@ -1,8 +1,10 @@ #pragma once +#include + namespace Bloom::Targets::Microchip::Avr::Avr8Bit { - enum class PhysicalInterface: int + enum class PhysicalInterface: std::uint8_t { JTAG, DEBUG_WIRE,