From a88b77df8a422b1c8d67ae8ff0e84b318c640e2d Mon Sep 17 00:00:00 2001
From: Nav <nav@navnav.me>
Date: Thu, 8 Sep 2022 19:57:04 +0100
Subject: [PATCH] Missing signal + tidying

---
 src/Insight/InsightSignals.hpp                             | 1 +
 src/Insight/InsightWorker/InsightWorker.cpp                | 1 +
 src/Insight/InsightWorker/Tasks/ReadTargetMemory.hpp       | 3 ++-
 src/Insight/InsightWorker/Tasks/ReadTargetRegisters.hpp    | 4 +++-
 src/Insight/InsightWorker/Tasks/RefreshTargetPinStates.hpp | 4 +++-
 src/Insight/InsightWorker/Tasks/SetTargetPinState.hpp      | 6 ++++--
 src/Insight/InsightWorker/Tasks/WriteTargetRegister.hpp    | 4 +++-
 7 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/src/Insight/InsightSignals.hpp b/src/Insight/InsightSignals.hpp
index 08eb9c5a..68453623 100644
--- a/src/Insight/InsightSignals.hpp
+++ b/src/Insight/InsightSignals.hpp
@@ -28,6 +28,7 @@ namespace Bloom
 
     signals:
         void taskQueued();
+        void taskProcessed();
 
         void targetStateUpdated(Bloom::Targets::TargetState newState);
         void targetReset();
diff --git a/src/Insight/InsightWorker/InsightWorker.cpp b/src/Insight/InsightWorker/InsightWorker.cpp
index 492345cc..4d58d4c5 100644
--- a/src/Insight/InsightWorker/InsightWorker.cpp
+++ b/src/Insight/InsightWorker/InsightWorker.cpp
@@ -83,6 +83,7 @@ namespace Bloom
             }
 
             task->deleteLater();
+            emit InsightSignals::instance()->taskProcessed();
         }
     }
 }
diff --git a/src/Insight/InsightWorker/Tasks/ReadTargetMemory.hpp b/src/Insight/InsightWorker/Tasks/ReadTargetMemory.hpp
index bbc8ee2f..9084d778 100644
--- a/src/Insight/InsightWorker/Tasks/ReadTargetMemory.hpp
+++ b/src/Insight/InsightWorker/Tasks/ReadTargetMemory.hpp
@@ -22,7 +22,8 @@ namespace Bloom
             : memoryType(memoryType)
             , startAddress(startAddress)
             , size(size)
-            , excludedAddressRanges(excludedAddressRanges) {}
+            , excludedAddressRanges(excludedAddressRanges)
+        {}
 
         TaskGroups getTaskGroups() const override {
             return TaskGroups({
diff --git a/src/Insight/InsightWorker/Tasks/ReadTargetRegisters.hpp b/src/Insight/InsightWorker/Tasks/ReadTargetRegisters.hpp
index cdfc8184..5d5a8283 100644
--- a/src/Insight/InsightWorker/Tasks/ReadTargetRegisters.hpp
+++ b/src/Insight/InsightWorker/Tasks/ReadTargetRegisters.hpp
@@ -10,7 +10,9 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        explicit ReadTargetRegisters(const Targets::TargetRegisterDescriptors& descriptors): descriptors(descriptors) {}
+        explicit ReadTargetRegisters(const Targets::TargetRegisterDescriptors& descriptors)
+            : descriptors(descriptors)
+        {}
 
         TaskGroups getTaskGroups() const override {
             return TaskGroups({
diff --git a/src/Insight/InsightWorker/Tasks/RefreshTargetPinStates.hpp b/src/Insight/InsightWorker/Tasks/RefreshTargetPinStates.hpp
index b829f87a..b5917b94 100644
--- a/src/Insight/InsightWorker/Tasks/RefreshTargetPinStates.hpp
+++ b/src/Insight/InsightWorker/Tasks/RefreshTargetPinStates.hpp
@@ -11,7 +11,9 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        explicit RefreshTargetPinStates(int variantId): variantId(variantId) {}
+        explicit RefreshTargetPinStates(int variantId)
+            : variantId(variantId)
+        {}
 
         TaskGroups getTaskGroups() const override {
             return TaskGroups({
diff --git a/src/Insight/InsightWorker/Tasks/SetTargetPinState.hpp b/src/Insight/InsightWorker/Tasks/SetTargetPinState.hpp
index 4e507088..312bbbaa 100644
--- a/src/Insight/InsightWorker/Tasks/SetTargetPinState.hpp
+++ b/src/Insight/InsightWorker/Tasks/SetTargetPinState.hpp
@@ -10,8 +10,10 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        SetTargetPinState(const Targets::TargetPinDescriptor& pinDescriptor, const Targets::TargetPinState& pinState):
-        pinDescriptor(pinDescriptor), pinState(pinState) {}
+        SetTargetPinState(const Targets::TargetPinDescriptor& pinDescriptor, const Targets::TargetPinState& pinState)
+            : pinDescriptor(pinDescriptor)
+            , pinState(pinState)
+        {}
 
         TaskGroups getTaskGroups() const override {
             return TaskGroups({
diff --git a/src/Insight/InsightWorker/Tasks/WriteTargetRegister.hpp b/src/Insight/InsightWorker/Tasks/WriteTargetRegister.hpp
index 3120b909..21b61127 100644
--- a/src/Insight/InsightWorker/Tasks/WriteTargetRegister.hpp
+++ b/src/Insight/InsightWorker/Tasks/WriteTargetRegister.hpp
@@ -10,7 +10,9 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        explicit WriteTargetRegister(const Targets::TargetRegister& targetRegister): targetRegister(targetRegister) {}
+        explicit WriteTargetRegister(const Targets::TargetRegister& targetRegister)
+            : targetRegister(targetRegister)
+        {}
 
         TaskGroups getTaskGroups() const override {
             return TaskGroups({