From a70b3e5878cc6692823fec5bc5005ece9d1c3dbb Mon Sep 17 00:00:00 2001
From: Nav <nav@navnav.me>
Date: Fri, 29 Nov 2024 01:07:09 +0000
Subject: [PATCH] Made `architecture` attribute mandatory in TDFs

---
 .../Services/ValidationService.php                     | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/build/scripts/Targets/TargetDescriptionFiles/Services/ValidationService.php b/build/scripts/Targets/TargetDescriptionFiles/Services/ValidationService.php
index 840e184a..5326f1ad 100644
--- a/build/scripts/Targets/TargetDescriptionFiles/Services/ValidationService.php
+++ b/build/scripts/Targets/TargetDescriptionFiles/Services/ValidationService.php
@@ -34,7 +34,7 @@ class ValidationService
         $failures = [];
 
         if (empty($tdf->getName())) {
-            $failures[] = 'Target name not found';
+            $failures[] = 'Missing/empty name attribute';
         }
 
         if (str_contains($tdf->getName(), ' ')) {
@@ -42,11 +42,15 @@ class ValidationService
         }
 
         if (empty($tdf->getFamily())) {
-            $failures[] = 'Missing/invalid target family';
+            $failures[] = 'Missing/invalid target family attribute';
         }
 
         if (empty($tdf->getConfigurationValue())) {
-            $failures[] = 'Missing configuration value';
+            $failures[] = 'Missing/empty configuration value attribute';
+        }
+
+        if (empty($tdf->getArchitecture())) {
+            $failures[] = 'Missing/empty architecture attribute';
         }
 
         if (empty($tdf->variants)) {