doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Used TC atomic session in GDB ReadRegisters handler, to prevent Insight causing delays in the GDB session.

Browse Source
This commit is contained in:
Nav
2023-06-01 22:16:05 +01:00
parent 30936fe0a2
commit 9f3761879a
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadRegisters.cpp
View File

@@ -4,6 +4,7 @@
#include "src/DebugServer/Gdb/AvrGdb/TargetDescriptor.hpp" #include "src/DebugServer/Gdb/AvrGdb/TargetDescriptor.hpp"
#include "src/Targets/TargetRegister.hpp" #include "src/Targets/TargetRegister.hpp"
#include "src/Targets/TargetMemory.hpp"
#include "src/Services/StringService.hpp" #include "src/Services/StringService.hpp"
#include "src/Logger/Logger.hpp" #include "src/Logger/Logger.hpp"
@@ -44,7 +45,15 @@ namespace Bloom::DebugServer::Gdb::AvrGdb::CommandPackets
} }
} }
auto registerSet = targetControllerService.readRegisters(descriptorIds); Targets::TargetRegisters registerSet;
Targets::TargetProgramCounter programCounter;
{
const auto atomicSession = targetControllerService.makeAtomicSession();
registerSet = targetControllerService.readRegisters(descriptorIds);
programCounter = targetControllerService.getProgramCounter();
}
/* /*
* Sort each register by their respective GDB register ID - this will leave us with a collection of * Sort each register by their respective GDB register ID - this will leave us with a collection of
@@ -81,7 +90,6 @@ namespace Bloom::DebugServer::Gdb::AvrGdb::CommandPackets
} }
// Finally, include the program counter (which GDB expects to reside at the end) // Finally, include the program counter (which GDB expects to reside at the end)
const auto programCounter = targetControllerService.getProgramCounter();
registers.insert(registers.end(), static_cast<unsigned char>(programCounter)); registers.insert(registers.end(), static_cast<unsigned char>(programCounter));
registers.insert(registers.end(), static_cast<unsigned char>(programCounter >> 8)); registers.insert(registers.end(), static_cast<unsigned char>(programCounter >> 8));
registers.insert(registers.end(), static_cast<unsigned char>(programCounter >> 16)); registers.insert(registers.end(), static_cast<unsigned char>(programCounter >> 16));