From 8ec4d664c96be9b4511ac4693fe5f19bf2e06007 Mon Sep 17 00:00:00 2001 From: Nav Date: Fri, 24 Dec 2021 02:55:59 +0000 Subject: [PATCH] Tidying --- src/DebugServers/GdbRsp/GdbRspDebugServer.cpp | 4 ++-- .../HexViewerWidget/ByteAddressContainer.cpp | 13 ------------- .../HexViewerWidget/ByteAddressContainer.hpp | 8 +++----- 3 files changed, 5 insertions(+), 20 deletions(-) diff --git a/src/DebugServers/GdbRsp/GdbRspDebugServer.cpp b/src/DebugServers/GdbRsp/GdbRspDebugServer.cpp index 6cef9577..a88e5800 100644 --- a/src/DebugServers/GdbRsp/GdbRspDebugServer.cpp +++ b/src/DebugServers/GdbRsp/GdbRspDebugServer.cpp @@ -147,8 +147,8 @@ void GdbRspDebugServer::handleGdbPacket(CommandPackets::WriteRegister& packet) { try { auto registerDescriptor = this->getRegisterDescriptorFromNumber(packet.registerNumber); this->targetControllerConsole.writeRegisters({ - TargetRegister(registerDescriptor, packet.registerValue) - }); + TargetRegister(registerDescriptor, packet.registerValue) + }); this->clientConnection->writePacket(ResponsePacket({'O', 'K'})); } catch (const Exception& exception) { diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ByteAddressContainer.cpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ByteAddressContainer.cpp index ff50b005..8d9af344 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ByteAddressContainer.cpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ByteAddressContainer.cpp @@ -1,18 +1,7 @@ #include "ByteAddressContainer.hpp" -#include -#include -#include -#include -#include - -#include "src/Logger/Logger.hpp" - using namespace Bloom::Widgets; -ByteAddressContainer::ByteAddressContainer() { -} - void ByteAddressContainer::adjustAddressLabels( const std::map>& byteItemsByRowIndex ) { @@ -56,8 +45,6 @@ void ByteAddressContainer::adjustAddressLabels( } } - Logger::error("Done with rows: " + std::to_string(this->addressItemsByRowIndex.size())); - this->update(); } diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ByteAddressContainer.hpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ByteAddressContainer.hpp index 572806b5..4dc08ccc 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ByteAddressContainer.hpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ByteAddressContainer.hpp @@ -2,12 +2,10 @@ #include #include -#include +#include #include -#include -#include -#include #include +#include #include "ByteItem.hpp" #include "ByteAddressItem.hpp" @@ -19,7 +17,7 @@ namespace Bloom::Widgets public: static constexpr int WIDTH = 85; - ByteAddressContainer(); + ByteAddressContainer() = default; [[nodiscard]] QRectF boundingRect() const override { return QRectF(