This commit is contained in:
Nav
2022-02-27 20:44:01 +00:00
parent 8cb60f442b
commit 8b6ee9f100
5 changed files with 7 additions and 7 deletions

View File

@@ -16,7 +16,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::CommandFrames
* 2. Version (0x00) * 2. Version (0x00)
* 3. Param context (Avr8Parameter::context) * 3. Param context (Avr8Parameter::context)
* 4. Param ID (Avr8Parameter::id) * 4. Param ID (Avr8Parameter::id)
* 5. Param value length (this->size) * 5. Param value length (size)
*/ */
this->payload = { this->payload = {
0x02, 0x02,

View File

@@ -12,13 +12,13 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::CommandFrames
const std::set<std::uint32_t>& excludedAddresses const std::set<std::uint32_t>& excludedAddresses
) { ) {
/* /*
* The read memory command consists of 11/11 + (this->bytes / 8) bytes: * The read memory command consists of 11 + (bytes / 8) bytes:
* 1. Command ID (0x21 for the general read memory command, 0x22 for reading with a mask) * 1. Command ID (0x21 for the general read memory command, 0x22 for reading with a mask)
* 2. Version (0x00) * 2. Version (0x00)
* 3. Memory type (Avr8MemoryType) * 3. Memory type (Avr8MemoryType)
* 4. Start address (4 bytes) * 4. Start address (4 bytes)
* 5. Number of bytes to read (4 bytes) * 5. Number of bytes to read (4 bytes)
* 6. Mask to apply (this->bytes / 8) - only required if we're using the masked read command (command ID 0x22). * 6. Mask to apply (bytes / 8) - only required if we're using the masked read command (command ID 0x22).
*/ */
this->payload = std::vector<unsigned char>(11, 0x00); this->payload = std::vector<unsigned char>(11, 0x00);
this->payload[0] = excludedAddresses.empty() ? 0x21 : 0x22; this->payload[0] = excludedAddresses.empty() ? 0x21 : 0x22;

View File

@@ -9,12 +9,12 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::CommandFrames
public: public:
SetParameter(const Avr8EdbgParameter& parameter, const std::vector<unsigned char>& value) { SetParameter(const Avr8EdbgParameter& parameter, const std::vector<unsigned char>& value) {
/* /*
* The set param command consists of this->value.size() + 5 bytes. The first five bytes consist of: * The set param command consists of value.size() + 5 bytes. The first five bytes consist of:
* 1. Command ID (0x01) * 1. Command ID (0x01)
* 2. Version (0x00) * 2. Version (0x00)
* 3. Param context (Avr8Parameter::context) * 3. Param context (Avr8Parameter::context)
* 4. Param ID (Avr8Parameter::id) * 4. Param ID (Avr8Parameter::id)
* 5. Param value length (this->value.size()) - this is only one byte in size, so its value should * 5. Param value length (value.size()) - this is only one byte in size, so its value should
* never exceed 255. * never exceed 255.
*/ */
this->payload = std::vector<unsigned char>(5, 0x00); this->payload = std::vector<unsigned char>(5, 0x00);

View File

@@ -17,7 +17,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::CommandFrames
* 2. Version (0x00) * 2. Version (0x00)
* 3. Param context (Parameter::context) * 3. Param context (Parameter::context)
* 4. Param ID (Parameter::id) * 4. Param ID (Parameter::id)
* 5. Param value length (this->size) * 5. Param value length (size)
*/ */
this->payload = { this->payload = {
0x02, 0x02,

View File

@@ -55,7 +55,7 @@ namespace Bloom::Targets::Microchip::Avr::Avr8Bit
void setDebugTool(DebugTool* debugTool) override { void setDebugTool(DebugTool* debugTool) override {
this->avr8DebugInterface = debugTool->getAvr8DebugInterface(); this->avr8DebugInterface = debugTool->getAvr8DebugInterface();
}; }
/** /**
* Instances to this target class can be promoted. See Avr8::promote() method for more. * Instances to this target class can be promoted. See Avr8::promote() method for more.