From 84b26aa4851379a5d8939090789483bc7dc00c74 Mon Sep 17 00:00:00 2001
From: Nav <nav@navnav.me>
Date: Sun, 7 Jul 2024 17:37:47 +0100
Subject: [PATCH] Corrected offset bug with target register group references,
 in TDF scripts

---
 .../TargetDescriptionFiles/TargetDescriptionFile.php      | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/build/scripts/Targets/TargetDescriptionFiles/TargetDescriptionFile.php b/build/scripts/Targets/TargetDescriptionFiles/TargetDescriptionFile.php
index a2df0a84..146d399f 100644
--- a/build/scripts/Targets/TargetDescriptionFiles/TargetDescriptionFile.php
+++ b/build/scripts/Targets/TargetDescriptionFiles/TargetDescriptionFile.php
@@ -83,6 +83,9 @@ class TargetDescriptionFile
         return $this->deviceAttributesByName['vendor'] ?? null;
     }
 
+    /**
+     * @return TargetPhysicalInterface[]
+     */
     public function getSupportedPhysicalInterfaces(): array
     {
         return array_filter(array_map(
@@ -91,6 +94,9 @@ class TargetDescriptionFile
         ));
     }
 
+    /**
+     * @return TargetPhysicalInterface[]
+     */
     public function getSupportedDebugPhysicalInterfaces(): array
     {
         return array_filter(
@@ -333,7 +339,7 @@ class TargetDescriptionFile
                     $subgroupReference->name,
                     $addressSpaceKey,
                     $subgroup,
-                    $addressOffset,
+                    $addressOffset + $subgroupReference->offset,
                     $moduleKey
                 );
             }