Tidying

src/Insight/UserInterfaces/InsightWindow/InsightWindow.cpp

@@ -160,7 +160,7 @@ namespace Bloom
             &InsightWindow::openAboutWindow
         );
 
-        // Tool bar button connections
+        // Toolbar button connections
         QObject::connect(
             this->refreshIoInspectionButton,
             &QToolButton::clicked,

src/Insight/UserInterfaces/InsightWindow/Widgets/RotatableLabel.cpp

@@ -53,8 +53,7 @@ namespace Bloom::Widgets
             size.setWidth(static_cast<int>(
                 std::cos(angleRadians) * textSize.width()
                 + std::ceil(std::sin(angleRadians) * textSize.height())
-            ))
+            ));
-            ;
             size.setHeight(static_cast<int>(
                 std::sin(angleRadians) * textSize.width()
                 + std::ceil(std::cos(angleRadians) * textSize.height())

src/Insight/UserInterfaces/InsightWindow/Widgets/RotatableLabel.hpp

@@ -12,7 +12,9 @@ namespace Bloom::Widgets
     public:
         RotatableLabel(const QString& text, QWidget* parent): QLabel(text, parent) {};
         RotatableLabel(int angleDegrees, const QString& text, QWidget* parent)
-        : QLabel(text, parent), angle(angleDegrees) {};
+            : QLabel(text, parent),
+            angle(angleDegrees)
+        {};
 
         void setAngle(int angleDegrees) {
             this->angle = angleDegrees;
@@ -23,11 +25,11 @@ namespace Bloom::Widgets
 
         [[nodiscard]] QSize sizeHint() const override {
             return this->getContainerSize();
-        };
+        }
 
         [[nodiscard]] QSize minimumSizeHint() const override {
             return this->getContainerSize();
-        };
+        }
 
     private:
         int angle = 90;

src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/TargetMemoryInspectionPane.cpp

@@ -12,23 +12,24 @@
 #include "src/Helpers/Paths.hpp"
 #include "src/Exceptions/Exception.hpp"
 
-using namespace Bloom::Widgets;
+namespace Bloom::Widgets
-using namespace Bloom::Exceptions;
+{
+    using namespace Bloom::Exceptions;
 
-using Bloom::Targets::TargetMemoryDescriptor;
+    using Bloom::Targets::TargetMemoryDescriptor;
-using Bloom::Targets::TargetMemoryType;
+    using Bloom::Targets::TargetMemoryType;
 
-TargetMemoryInspectionPane::TargetMemoryInspectionPane(
+    TargetMemoryInspectionPane::TargetMemoryInspectionPane(
         const TargetMemoryDescriptor& targetMemoryDescriptor,
         TargetMemoryInspectionPaneSettings& settings,
         InsightWorker& insightWorker,
         PanelWidget* parent
-)
+    )
         : PaneWidget(parent)
         , targetMemoryDescriptor(targetMemoryDescriptor)
         , settings(settings)
         , insightWorker(insightWorker)
-{
+    {
         this->setObjectName("target-memory-inspection-pane");
 
         auto memoryInspectionPaneUiFile = QFile(
@@ -92,9 +93,9 @@ TargetMemoryInspectionPane::TargetMemoryInspectionPane(
                 this->refreshMemoryValues();
             }
         );
-}
+    }
 
-void TargetMemoryInspectionPane::refreshMemoryValues(std::optional<std::function<void(void)>> callback) {
+    void TargetMemoryInspectionPane::refreshMemoryValues(std::optional<std::function<void(void)>> callback) {
         this->hexViewerWidget->refreshButton->setDisabled(true);
         this->hexViewerWidget->refreshButton->startSpin();
 
@@ -162,39 +163,39 @@ void TargetMemoryInspectionPane::refreshMemoryValues(std::optional<std::function
         }
 
         this->insightWorker.queueTask(readMemoryTask);
-}
+    }
 
-void TargetMemoryInspectionPane::activate() {
+    void TargetMemoryInspectionPane::activate() {
         this->show();
         this->activated = true;
         this->postActivate();
-}
+    }
 
-void TargetMemoryInspectionPane::deactivate() {
+    void TargetMemoryInspectionPane::deactivate() {
         this->hide();
         this->activated = false;
         this->postDeactivate();
-}
+    }
 
-void TargetMemoryInspectionPane::resizeEvent(QResizeEvent* event) {
+    void TargetMemoryInspectionPane::resizeEvent(QResizeEvent* event) {
         const auto parentSize = this->parentPanel->size();
         const auto width = parentSize.width() - 1;
         this->container->setFixedSize(width, parentSize.height());
-}
+    }
 
-void TargetMemoryInspectionPane::postActivate() {
+    void TargetMemoryInspectionPane::postActivate() {
         if (this->targetState == Targets::TargetState::STOPPED) {
             this->refreshMemoryValues([this] {
                 this->hexViewerWidget->setDisabled(false);
             });
         }
-}
+    }
 
-void TargetMemoryInspectionPane::postDeactivate() {
+    void TargetMemoryInspectionPane::postDeactivate() {
 
-}
+    }
 
-void TargetMemoryInspectionPane::sanitiseSettings() {
+    void TargetMemoryInspectionPane::sanitiseSettings() {
         // Remove any invalid memory regions. It's very unlikely that there will be any, but not impossible.
         auto processedFocusedMemoryRegions = std::vector<FocusedMemoryRegion>();
         auto processedExcludedMemoryRegions = std::vector<ExcludedMemoryRegion>();
@@ -240,9 +241,9 @@ void TargetMemoryInspectionPane::sanitiseSettings() {
 
         this->settings.focusedMemoryRegions = std::move(processedFocusedMemoryRegions);
         this->settings.excludedMemoryRegions = std::move(processedExcludedMemoryRegions);
-}
+    }
 
-void TargetMemoryInspectionPane::onTargetStateChanged(Targets::TargetState newState) {
+    void TargetMemoryInspectionPane::onTargetStateChanged(Targets::TargetState newState) {
         if (this->targetState == newState) {
             return;
         }
@@ -258,13 +259,13 @@ void TargetMemoryInspectionPane::onTargetStateChanged(Targets::TargetState newSt
         } else if (newState == TargetState::RUNNING) {
             this->hexViewerWidget->setDisabled(true);
         }
-}
+    }
 
-void TargetMemoryInspectionPane::onMemoryRead(const Targets::TargetMemoryBuffer& buffer) {
+    void TargetMemoryInspectionPane::onMemoryRead(const Targets::TargetMemoryBuffer& buffer) {
         this->hexViewerWidget->updateValues(buffer);
-}
+    }
 
-void TargetMemoryInspectionPane::openMemoryRegionManagerWindow() {
+    void TargetMemoryInspectionPane::openMemoryRegionManagerWindow() {
         if (this->memoryRegionManagerWindow == nullptr) {
             this->memoryRegionManagerWindow = new MemoryRegionManagerWindow(
                 this->targetMemoryDescriptor,
@@ -289,8 +290,9 @@ void TargetMemoryInspectionPane::openMemoryRegionManagerWindow() {
         } else {
             this->memoryRegionManagerWindow->activateWindow();
         }
-}
+    }
 
-void TargetMemoryInspectionPane::onMemoryRegionsChange() {
+    void TargetMemoryInspectionPane::onMemoryRegionsChange() {
         this->hexViewerWidget->refreshRegions();
+    }
 }

src/Insight/UserInterfaces/InsightWindow/Widgets/TargetRegisterInspector/TargetRegisterInspectorWindow.cpp

@@ -9,7 +9,6 @@
 #include "src/Insight/UserInterfaces/InsightWindow/Widgets/ErrorDialogue/ErrorDialogue.hpp"
 
 #include "src/Helpers/Paths.hpp"
-#include "src/Helpers/DateTime.hpp"
 #include "src/Exceptions/Exception.hpp"
 
 #include "src/Insight/InsightWorker/Tasks/ReadTargetRegisters.hpp"

src/Insight/UserInterfaces/InsightWindow/Widgets/TargetRegistersPane/TargetRegistersPaneWidget.cpp

@@ -25,7 +25,11 @@ namespace Bloom::Widgets
         const TargetDescriptor& targetDescriptor,
         InsightWorker& insightWorker,
         PanelWidget* parent
-    ): PaneWidget(parent), targetDescriptor(targetDescriptor), insightWorker(insightWorker) {
+    )
+        : PaneWidget(parent)
+        , targetDescriptor(targetDescriptor)
+        , insightWorker(insightWorker)
+    {
         this->setObjectName("target-registers-side-pane");
 
         auto targetRegistersPaneUiFile = QFile(

src/Insight/UserInterfaces/InsightWindow/Widgets/TargetWidgets/TargetPackageWidget.cpp

@@ -12,7 +12,11 @@ namespace Bloom::Widgets::InsightTargetWidgets
         Targets::TargetVariant targetVariant,
         InsightWorker& insightWorker,
         QWidget* parent
-    ): QWidget(parent), targetVariant(std::move(targetVariant)), insightWorker(insightWorker) {
+    )
+        : QWidget(parent)
+        , targetVariant(std::move(targetVariant))
+        , insightWorker(insightWorker)
+    {
         QObject::connect(
             &(this->insightWorker),
             &InsightWorker::targetStateUpdated,

src/TargetController/Commands/ReadTargetMemory.hpp

@@ -3,7 +3,7 @@
 #include "Command.hpp"
 #include "src/TargetController/Responses/TargetMemoryRead.hpp"
 
-#include "src/Targets/TargetRegister.hpp"
+#include "src/Targets/TargetMemory.hpp"
 
 namespace Bloom::TargetController::Commands
 {