doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disabling breakAfterAttach function for JTAG sessions

Browse Source
This commit is contained in:
Nav
2021-05-02 15:46:18 +01:00
parent de1d80f35b
commit 7112f90e70
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp
View File

@@ -367,7 +367,17 @@ void EdbgAvr8Interface::deactivatePhysical() {
} }
void EdbgAvr8Interface::attach() { void EdbgAvr8Interface::attach() {
auto commandFrame = CommandFrames::Avr8Generic::Attach(true); /*
* When attaching an ATmega target that is connected via JTAG, we must not set the breakAfterAttach flag, as this
* results in a timeout.
*
* However, in this case the attach command seems to _sometimes_ halt the target anyway, regardless of the
* value of the breakAfterAttach flag. So we still expect a stop event to be received shortly after issuing
* the attach command.
*/
auto commandFrame = CommandFrames::Avr8Generic::Attach(
this->configVariant != Avr8ConfigVariant::MEGAJTAG
);
auto response = this->edbgInterface.sendAvrCommandFrameAndWaitForResponseFrame(commandFrame); auto response = this->edbgInterface.sendAvrCommandFrameAndWaitForResponseFrame(commandFrame);
if (response.getResponseId() == Avr8ResponseId::FAILED) { if (response.getResponseId() == Avr8ResponseId::FAILED) {
@@ -376,8 +386,13 @@ void EdbgAvr8Interface::attach() {
this->targetAttached = true; this->targetAttached = true;
// Wait for stopped event try {
this->waitForStoppedEvent(); // Wait for stopped event
this->waitForStoppedEvent();
} catch (const Exception& exception) {
Logger::error("Execution on AVR8 target could not be halted post attach - " + exception.getMessage());
}
} }
void EdbgAvr8Interface::detach() { void EdbgAvr8Interface::detach() {