Tidying

src/Insight/InsightWorker/Tasks/QueryLatestVersionNumber.hpp

@@ -11,8 +11,8 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        QueryLatestVersionNumber(const VersionNumber& currentVersionNumber):
+        explicit QueryLatestVersionNumber(const VersionNumber& currentVersionNumber):
-        InsightWorkerTask(), currentVersionNumber(currentVersionNumber) {}
+        currentVersionNumber(currentVersionNumber) {}
 
     signals:
         void latestVersionNumberRetrieved(const VersionNumber& latestVersionNumber);

src/Insight/InsightWorker/Tasks/ReadStackPointer.hpp

@@ -9,7 +9,7 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        ReadStackPointer(): InsightWorkerTask() {}
+        ReadStackPointer() = default;
 
     signals:
         void stackPointerRead(std::uint32_t stackPointer);

src/Insight/InsightWorker/Tasks/ReadTargetMemory.hpp

@@ -18,11 +18,11 @@ namespace Bloom
             std::uint32_t startAddress,
             std::uint32_t size,
             const std::set<Targets::TargetMemoryAddressRange>& excludedAddressRanges = {}
-        ):
+        )
-            memoryType(memoryType),
+            : memoryType(memoryType)
-            startAddress(startAddress),
+            , startAddress(startAddress)
-            size(size),
+            , size(size)
-            excludedAddressRanges(excludedAddressRanges) {}
+            , excludedAddressRanges(excludedAddressRanges) {}
 
     signals:
         void targetMemoryRead(Targets::TargetMemoryBuffer buffer);

src/Insight/InsightWorker/Tasks/ReadTargetRegisters.hpp

@@ -10,8 +10,7 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        ReadTargetRegisters(const Targets::TargetRegisterDescriptors& descriptors):
+        explicit ReadTargetRegisters(const Targets::TargetRegisterDescriptors& descriptors): descriptors(descriptors) {}
-        InsightWorkerTask(), descriptors(descriptors) {}
 
     signals:
         void targetRegistersRead(Targets::TargetRegisters registers);

src/Insight/InsightWorker/Tasks/RefreshTargetPinStates.hpp

@@ -11,7 +11,7 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        RefreshTargetPinStates(int variantId): InsightWorkerTask(), variantId(variantId) {}
+        explicit RefreshTargetPinStates(int variantId): variantId(variantId) {}
 
     signals:
         void targetPinStatesRetrieved(Bloom::Targets::TargetPinStateMappingType pinStatesByNumber);

src/Insight/InsightWorker/Tasks/SetTargetPinState.hpp

@@ -11,7 +11,7 @@ namespace Bloom
 
     public:
         SetTargetPinState(const Targets::TargetPinDescriptor& pinDescriptor, const Targets::TargetPinState& pinState):
-        InsightWorkerTask(), pinDescriptor(pinDescriptor), pinState(pinState) {}
+        pinDescriptor(pinDescriptor), pinState(pinState) {}
 
     protected:
         void run(TargetControllerConsole& targetControllerConsole) override;

src/Insight/InsightWorker/Tasks/WriteTargetRegister.hpp

@@ -10,8 +10,7 @@ namespace Bloom
         Q_OBJECT
 
     public:
-        WriteTargetRegister(const Targets::TargetRegister& targetRegister):
+        explicit WriteTargetRegister(const Targets::TargetRegister& targetRegister): targetRegister(targetRegister) {}
-        InsightWorkerTask(), targetRegister(targetRegister) {}
 
     protected:
         void run(TargetControllerConsole& targetControllerConsole) override;

src/SignalHandler/SignalHandler.cpp

@@ -74,7 +74,7 @@ namespace Bloom
         if (this->shutdownSignalsReceived > 1) {
             // User has likely run out of patience
             Logger::warning("Aborting immediately");
-            exit(EXIT_FAILURE);
+            std::exit(EXIT_FAILURE);
         }
 
         Logger::info("Attempting clean shutdown");