doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enforce flash page alignment for UPDI targets, when accessing flash

Browse Source
This commit is contained in:
Nav
2022-09-17 19:55:55 +01:00
parent 9f9a67688e
commit 65bdcd62d3
1 changed files with 16 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp
View File

@@ -1469,32 +1469,13 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
) { ) {
std::uint16_t alignTo = 1; std::uint16_t alignTo = 1;
// We don't have to align to the page size in all cases. We may only need to align to the word size (2 bytes). if (
switch (memoryType) { memoryType == Avr8MemoryType::FLASH_PAGE
case Avr8MemoryType::FLASH_PAGE: { || memoryType == Avr8MemoryType::SPM
alignTo = (this->configVariant == Avr8ConfigVariant::UPDI) || memoryType == Avr8MemoryType::APPL_FLASH
? 2 || memoryType == Avr8MemoryType::BOOT_FLASH
: this->targetParameters.flashPageSize.value(); ) {
break; alignTo = this->targetParameters.flashPageSize.value();
}
case Avr8MemoryType::SPM: {
// Memory access via the SPM type must be word aligned.
alignTo = 2;
}
case Avr8MemoryType::APPL_FLASH:
case Avr8MemoryType::BOOT_FLASH: {
if (this->configVariant == Avr8ConfigVariant::UPDI) {
// For UPDI sessions, memory access via the APPL_FLASH must be word aligned.
alignTo = 2;
} else {
alignTo = this->targetParameters.flashPageSize.value();
}
break;
}
default: {
break;
}
} }
if (this->maximumMemoryAccessSizePerRequest.has_value() && alignTo > this->maximumMemoryAccessSizePerRequest) { if (this->maximumMemoryAccessSizePerRequest.has_value() && alignTo > this->maximumMemoryAccessSizePerRequest) {
@@ -1518,32 +1499,13 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
) { ) {
std::uint16_t alignTo = 1; std::uint16_t alignTo = 1;
// We don't have to align to the page size in all cases. We may only need to align to the word size (2 bytes). if (
switch (memoryType) { memoryType == Avr8MemoryType::FLASH_PAGE
case Avr8MemoryType::FLASH_PAGE: { || memoryType == Avr8MemoryType::SPM
alignTo = (this->configVariant == Avr8ConfigVariant::UPDI) || memoryType == Avr8MemoryType::APPL_FLASH
? 2 || memoryType == Avr8MemoryType::BOOT_FLASH
: this->targetParameters.flashPageSize.value(); ) {
break; alignTo = this->targetParameters.flashPageSize.value();
}
case Avr8MemoryType::SPM: {
// Memory access via the SPM type must be word aligned.
alignTo = 2;
}
case Avr8MemoryType::APPL_FLASH:
case Avr8MemoryType::BOOT_FLASH: {
if (this->configVariant == Avr8ConfigVariant::UPDI) {
// For UPDI sessions, memory access via the APPL_FLASH must be word aligned.
alignTo = 2;
} else {
alignTo = this->targetParameters.flashPageSize.value();
}
break;
}
default: {
break;
}
} }
if ((bytes % alignTo) != 0) { if ((bytes % alignTo) != 0) {
@@ -1718,8 +1680,8 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
for (float i = 1; i <= totalReadsRequired; i++) { for (float i = 1; i <= totalReadsRequired; i++) {
auto bytesToRead = static_cast<TargetMemorySize>( auto bytesToRead = static_cast<TargetMemorySize>(
(bytes - output.size()) > (singlePacketSize * 2) ? (singlePacketSize * 2) (bytes - output.size()) > (singlePacketSize * 2)
: bytes - output.size() ? (singlePacketSize * 2) : bytes - output.size()
); );
auto data = this->readMemory( auto data = this->readMemory(
type, type,