From 61d608989dbf80e6960c915e015acdc285d51558 Mon Sep 17 00:00:00 2001 From: Nav Date: Sun, 7 May 2023 20:17:33 +0100 Subject: [PATCH] Changed GDB "Handling..." logs to INFO level --- src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashDone.cpp | 2 +- src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashErase.cpp | 2 +- src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashWrite.cpp | 2 +- src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemory.cpp | 2 +- src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemoryMap.cpp | 2 +- src/DebugServer/Gdb/AvrGdb/CommandPackets/WriteMemory.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/BloomVersion.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/BloomVersionMachine.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/CommandPacket.cpp | 4 ++-- src/DebugServer/Gdb/CommandPackets/ContinueExecution.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/Detach.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/EepromFill.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/GenerateSvd.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/HelpMonitorInfo.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/InterruptExecution.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/ReadRegisters.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/RemoveBreakpoint.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/ResetTarget.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/SetBreakpoint.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/StepExecution.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/SupportedFeaturesQuery.cpp | 2 +- src/DebugServer/Gdb/CommandPackets/WriteRegister.cpp | 2 +- 22 files changed, 23 insertions(+), 23 deletions(-) diff --git a/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashDone.cpp b/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashDone.cpp index 85b5985b..50d5ba05 100644 --- a/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashDone.cpp +++ b/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashDone.cpp @@ -20,7 +20,7 @@ namespace Bloom::DebugServer::Gdb::AvrGdb::CommandPackets {} void FlashDone::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling FlashDone packet"); + Logger::info("Handling FlashDone packet"); try { if (debugSession.programmingSession.has_value()) { diff --git a/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashErase.cpp b/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashErase.cpp index 80d2cfa9..686995db 100644 --- a/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashErase.cpp +++ b/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashErase.cpp @@ -49,7 +49,7 @@ namespace Bloom::DebugServer::Gdb::AvrGdb::CommandPackets } void FlashErase::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling FlashErase packet"); + Logger::info("Handling FlashErase packet"); try { targetControllerService.enableProgrammingMode(); diff --git a/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashWrite.cpp b/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashWrite.cpp index 063fdeea..57d179eb 100644 --- a/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashWrite.cpp +++ b/src/DebugServer/Gdb/AvrGdb/CommandPackets/FlashWrite.cpp @@ -49,7 +49,7 @@ namespace Bloom::DebugServer::Gdb::AvrGdb::CommandPackets } void FlashWrite::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling FlashWrite packet"); + Logger::info("Handling FlashWrite packet"); try { if (this->buffer.empty()) { diff --git a/src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemory.cpp b/src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemory.cpp index d4025a11..011eadbb 100644 --- a/src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemory.cpp +++ b/src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemory.cpp @@ -63,7 +63,7 @@ namespace Bloom::DebugServer::Gdb::AvrGdb::CommandPackets } void ReadMemory::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling ReadMemory packet"); + Logger::info("Handling ReadMemory packet"); try { const auto& memoryDescriptorsByType = debugSession.gdbTargetDescriptor.targetDescriptor.memoryDescriptorsByType; diff --git a/src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemoryMap.cpp b/src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemoryMap.cpp index 0fb8f0e0..4faaa4e0 100644 --- a/src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemoryMap.cpp +++ b/src/DebugServer/Gdb/AvrGdb/CommandPackets/ReadMemoryMap.cpp @@ -51,7 +51,7 @@ namespace Bloom::DebugServer::Gdb::AvrGdb::CommandPackets } void ReadMemoryMap::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling ReadMemoryMap packet"); + Logger::info("Handling ReadMemoryMap packet"); using Targets::TargetMemoryType; const auto& memoryDescriptorsByType = debugSession.gdbTargetDescriptor.targetDescriptor.memoryDescriptorsByType; diff --git a/src/DebugServer/Gdb/AvrGdb/CommandPackets/WriteMemory.cpp b/src/DebugServer/Gdb/AvrGdb/CommandPackets/WriteMemory.cpp index 2a85098d..44113e5a 100644 --- a/src/DebugServer/Gdb/AvrGdb/CommandPackets/WriteMemory.cpp +++ b/src/DebugServer/Gdb/AvrGdb/CommandPackets/WriteMemory.cpp @@ -69,7 +69,7 @@ namespace Bloom::DebugServer::Gdb::AvrGdb::CommandPackets } void WriteMemory::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling WriteMemory packet"); + Logger::info("Handling WriteMemory packet"); try { const auto& memoryDescriptorsByType = debugSession.gdbTargetDescriptor.targetDescriptor.memoryDescriptorsByType; diff --git a/src/DebugServer/Gdb/CommandPackets/BloomVersion.cpp b/src/DebugServer/Gdb/CommandPackets/BloomVersion.cpp index e9e0a0b4..a78a8a18 100644 --- a/src/DebugServer/Gdb/CommandPackets/BloomVersion.cpp +++ b/src/DebugServer/Gdb/CommandPackets/BloomVersion.cpp @@ -27,7 +27,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets {} void BloomVersion::handle(DebugSession& debugSession, TargetControllerService&) { - Logger::debug("Handling BloomVersion packet"); + Logger::info("Handling BloomVersion packet"); debugSession.connection.writePacket(ResponsePacket(Services::StringService::toHex( std::string( diff --git a/src/DebugServer/Gdb/CommandPackets/BloomVersionMachine.cpp b/src/DebugServer/Gdb/CommandPackets/BloomVersionMachine.cpp index 5e79f5e4..0c69e576 100644 --- a/src/DebugServer/Gdb/CommandPackets/BloomVersionMachine.cpp +++ b/src/DebugServer/Gdb/CommandPackets/BloomVersionMachine.cpp @@ -26,7 +26,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets {} void BloomVersionMachine::handle(DebugSession& debugSession, TargetControllerService&) { - Logger::debug("Handling BloomVersionMachine packet"); + Logger::info("Handling BloomVersionMachine packet"); debugSession.connection.writePacket(ResponsePacket(Services::StringService::toHex( QJsonDocument(QJsonObject({ diff --git a/src/DebugServer/Gdb/CommandPackets/CommandPacket.cpp b/src/DebugServer/Gdb/CommandPackets/CommandPacket.cpp index 6f5320e2..b947babd 100644 --- a/src/DebugServer/Gdb/CommandPackets/CommandPacket.cpp +++ b/src/DebugServer/Gdb/CommandPackets/CommandPacket.cpp @@ -39,13 +39,13 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } if (packetString.find("vMustReplyEmpty") == 0) { - Logger::debug("Handling vMustReplyEmpty"); + Logger::info("Handling vMustReplyEmpty"); debugSession.connection.writePacket(EmptyResponsePacket()); return; } if (packetString.find("qAttached") == 0) { - Logger::debug("Handling qAttached"); + Logger::info("Handling qAttached"); debugSession.connection.writePacket(ResponsePacket(std::vector({1}))); return; } diff --git a/src/DebugServer/Gdb/CommandPackets/ContinueExecution.cpp b/src/DebugServer/Gdb/CommandPackets/ContinueExecution.cpp index 5a7110e1..c2c4f856 100644 --- a/src/DebugServer/Gdb/CommandPackets/ContinueExecution.cpp +++ b/src/DebugServer/Gdb/CommandPackets/ContinueExecution.cpp @@ -23,7 +23,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } void ContinueExecution::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling ContinueExecution packet"); + Logger::info("Handling ContinueExecution packet"); try { targetControllerService.continueTargetExecution(this->fromAddress, std::nullopt); diff --git a/src/DebugServer/Gdb/CommandPackets/Detach.cpp b/src/DebugServer/Gdb/CommandPackets/Detach.cpp index e2177381..73ef16ed 100644 --- a/src/DebugServer/Gdb/CommandPackets/Detach.cpp +++ b/src/DebugServer/Gdb/CommandPackets/Detach.cpp @@ -21,7 +21,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets {} void Detach::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling Detach packet"); + Logger::info("Handling Detach packet"); try { if (Services::ProcessService::isManagedByClion()) { diff --git a/src/DebugServer/Gdb/CommandPackets/EepromFill.cpp b/src/DebugServer/Gdb/CommandPackets/EepromFill.cpp index 0043fcae..9ebb1155 100644 --- a/src/DebugServer/Gdb/CommandPackets/EepromFill.cpp +++ b/src/DebugServer/Gdb/CommandPackets/EepromFill.cpp @@ -35,7 +35,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } void EepromFill::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling EepromFill packet"); + Logger::info("Handling EepromFill packet"); try { const auto& targetDescriptor = debugSession.gdbTargetDescriptor.targetDescriptor; diff --git a/src/DebugServer/Gdb/CommandPackets/GenerateSvd.cpp b/src/DebugServer/Gdb/CommandPackets/GenerateSvd.cpp index cadfbc74..eb7a0539 100644 --- a/src/DebugServer/Gdb/CommandPackets/GenerateSvd.cpp +++ b/src/DebugServer/Gdb/CommandPackets/GenerateSvd.cpp @@ -29,7 +29,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets {} void GenerateSvd::handle(DebugSession& debugSession, TargetControllerService&) { - Logger::debug("Handling GenerateSvd packet"); + Logger::info("Handling GenerateSvd packet"); try { Logger::info("Generating SVD XML for current target"); diff --git a/src/DebugServer/Gdb/CommandPackets/HelpMonitorInfo.cpp b/src/DebugServer/Gdb/CommandPackets/HelpMonitorInfo.cpp index 916bb257..282b60f1 100644 --- a/src/DebugServer/Gdb/CommandPackets/HelpMonitorInfo.cpp +++ b/src/DebugServer/Gdb/CommandPackets/HelpMonitorInfo.cpp @@ -26,7 +26,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets {} void HelpMonitorInfo::handle(DebugSession& debugSession, TargetControllerService&) { - Logger::debug("Handling HelpMonitorInfo packet"); + Logger::info("Handling HelpMonitorInfo packet"); try { /* diff --git a/src/DebugServer/Gdb/CommandPackets/InterruptExecution.cpp b/src/DebugServer/Gdb/CommandPackets/InterruptExecution.cpp index 0cac58fb..62b7df78 100644 --- a/src/DebugServer/Gdb/CommandPackets/InterruptExecution.cpp +++ b/src/DebugServer/Gdb/CommandPackets/InterruptExecution.cpp @@ -16,7 +16,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets using Exceptions::Exception; void InterruptExecution::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling InterruptExecution packet"); + Logger::info("Handling InterruptExecution packet"); if (targetControllerService.getTargetState() == Targets::TargetState::STOPPED) { debugSession.pendingInterrupt = true; diff --git a/src/DebugServer/Gdb/CommandPackets/ReadRegisters.cpp b/src/DebugServer/Gdb/CommandPackets/ReadRegisters.cpp index 245bcca6..ac39d936 100644 --- a/src/DebugServer/Gdb/CommandPackets/ReadRegisters.cpp +++ b/src/DebugServer/Gdb/CommandPackets/ReadRegisters.cpp @@ -33,7 +33,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } void ReadRegisters::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling ReadRegisters packet"); + Logger::info("Handling ReadRegisters packet"); try { const auto& targetDescriptor = debugSession.gdbTargetDescriptor; diff --git a/src/DebugServer/Gdb/CommandPackets/RemoveBreakpoint.cpp b/src/DebugServer/Gdb/CommandPackets/RemoveBreakpoint.cpp index 1a048a92..a7594525 100644 --- a/src/DebugServer/Gdb/CommandPackets/RemoveBreakpoint.cpp +++ b/src/DebugServer/Gdb/CommandPackets/RemoveBreakpoint.cpp @@ -51,7 +51,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } void RemoveBreakpoint::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling RemoveBreakpoint packet"); + Logger::info("Handling RemoveBreakpoint packet"); try { Logger::debug("Removing breakpoint at address " + std::to_string(this->address)); diff --git a/src/DebugServer/Gdb/CommandPackets/ResetTarget.cpp b/src/DebugServer/Gdb/CommandPackets/ResetTarget.cpp index c7137c7e..981fb450 100644 --- a/src/DebugServer/Gdb/CommandPackets/ResetTarget.cpp +++ b/src/DebugServer/Gdb/CommandPackets/ResetTarget.cpp @@ -22,7 +22,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets {} void ResetTarget::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling ResetTarget packet"); + Logger::info("Handling ResetTarget packet"); try { Logger::warning("Resetting target"); diff --git a/src/DebugServer/Gdb/CommandPackets/SetBreakpoint.cpp b/src/DebugServer/Gdb/CommandPackets/SetBreakpoint.cpp index 14af0c02..a0b99f10 100644 --- a/src/DebugServer/Gdb/CommandPackets/SetBreakpoint.cpp +++ b/src/DebugServer/Gdb/CommandPackets/SetBreakpoint.cpp @@ -53,7 +53,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } void SetBreakpoint::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling SetBreakpoint packet"); + Logger::info("Handling SetBreakpoint packet"); try { if (this->type == BreakpointType::UNKNOWN) { diff --git a/src/DebugServer/Gdb/CommandPackets/StepExecution.cpp b/src/DebugServer/Gdb/CommandPackets/StepExecution.cpp index 20ba1e46..def90694 100644 --- a/src/DebugServer/Gdb/CommandPackets/StepExecution.cpp +++ b/src/DebugServer/Gdb/CommandPackets/StepExecution.cpp @@ -24,7 +24,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } void StepExecution::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling StepExecution packet"); + Logger::info("Handling StepExecution packet"); try { targetControllerService.stepTargetExecution(this->fromAddress); diff --git a/src/DebugServer/Gdb/CommandPackets/SupportedFeaturesQuery.cpp b/src/DebugServer/Gdb/CommandPackets/SupportedFeaturesQuery.cpp index d4b92839..53b4a5de 100644 --- a/src/DebugServer/Gdb/CommandPackets/SupportedFeaturesQuery.cpp +++ b/src/DebugServer/Gdb/CommandPackets/SupportedFeaturesQuery.cpp @@ -54,7 +54,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } void SupportedFeaturesQuery::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling QuerySupport packet"); + Logger::info("Handling QuerySupport packet"); if (!this->isFeatureSupported(Feature::HARDWARE_BREAKPOINTS) && !this->isFeatureSupported(Feature::SOFTWARE_BREAKPOINTS) diff --git a/src/DebugServer/Gdb/CommandPackets/WriteRegister.cpp b/src/DebugServer/Gdb/CommandPackets/WriteRegister.cpp index 1d497bad..a9f12b38 100644 --- a/src/DebugServer/Gdb/CommandPackets/WriteRegister.cpp +++ b/src/DebugServer/Gdb/CommandPackets/WriteRegister.cpp @@ -43,7 +43,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets } void WriteRegister::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) { - Logger::debug("Handling WriteRegister packet"); + Logger::info("Handling WriteRegister packet"); try { auto targetRegisterDescriptor = debugSession.gdbTargetDescriptor.getTargetRegisterDescriptorFromNumber(