Removed using namespace directive for class member function definitions in source files

src/DebugToolDrivers/Microchip/XplainedPro/XplainedPro.cpp

@@ -3,91 +3,99 @@
 #include "src/TargetController/Exceptions/DeviceFailure.hpp"
 #include "src/TargetController/Exceptions/DeviceInitializationFailure.hpp"
 
-using namespace Bloom::DebugToolDrivers;
-using namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr;
-using namespace Bloom::Exceptions;
+namespace Bloom::DebugToolDrivers
+{
+    using namespace Protocols::CmsisDap::Edbg::Avr;
+    using namespace Bloom::Exceptions;
 
-void XplainedPro::init() {
-    UsbDevice::init();
+    void XplainedPro::init() {
+        UsbDevice::init();
 
-    // TODO: Move away from hard-coding the CMSIS-DAP/EDBG interface number
-    auto& usbHidInterface = this->getEdbgInterface().getUsbHidInterface();
-    usbHidInterface.setNumber(0);
-    usbHidInterface.setLibUsbDevice(this->libUsbDevice);
-    usbHidInterface.setLibUsbDeviceHandle(this->libUsbDeviceHandle);
-    usbHidInterface.setVendorId(this->vendorId);
-    usbHidInterface.setProductId(this->productId);
+        // TODO: Move away from hard-coding the CMSIS-DAP/EDBG interface number
+        auto& usbHidInterface = this->getEdbgInterface().getUsbHidInterface();
+        usbHidInterface.setNumber(0);
+        usbHidInterface.setLibUsbDevice(this->libUsbDevice);
+        usbHidInterface.setLibUsbDeviceHandle(this->libUsbDeviceHandle);
+        usbHidInterface.setVendorId(this->vendorId);
+        usbHidInterface.setProductId(this->productId);
 
-    if (!usbHidInterface.isInitialised()) {
-        usbHidInterface.detachKernelDriver();
-        usbHidInterface.init();
+        if (!usbHidInterface.isInitialised()) {
+            usbHidInterface.detachKernelDriver();
+            usbHidInterface.init();
+        }
+
+        this->getEdbgInterface().setMinimumCommandTimeGap(std::chrono::milliseconds(35));
+
+        if (!this->sessionStarted) {
+            this->startSession();
+        }
+
+        this->edbgAvr8Interface = std::make_unique<EdbgAvr8Interface>(this->edbgInterface);
+
+        /*
+         * The Xplained Pro debug tool returns incorrect data for any read memory command that exceeds 256 bytes in the
+         * size of the read request, despite the fact that the HID report size is 512 bytes. The debug tool doesn't
+         * report any error, it just returns incorrect data.
+         *
+         * This means we must enforce a hard limit on the number of bytes we attempt to access, per request.
+         */
+        this->edbgAvr8Interface->setMaximumMemoryAccessSizePerRequest(256);
+        this->setInitialised(true);
     }
 
-    this->getEdbgInterface().setMinimumCommandTimeGap(std::chrono::milliseconds(35));
+    void XplainedPro::close() {
+        if (this->sessionStarted) {
+            this->endSession();
+        }
 
-    if (!this->sessionStarted) {
-        this->startSession();
+        this->getEdbgInterface().getUsbHidInterface().close();
+        UsbDevice::close();
     }
 
-    this->edbgAvr8Interface = std::make_unique<EdbgAvr8Interface>(this->edbgInterface);
+    std::string XplainedPro::getSerialNumber() {
+        using namespace CommandFrames::Discovery;
 
-    /*
-     * The Xplained Pro debug tool returns incorrect data for any read memory command that exceeds 256 bytes in the
-     * size of the read request, despite the fact that the HID report size is 512 bytes. The debug tool doesn't
-     * report any error, it just returns incorrect data.
-     *
-     * This means we must enforce a hard limit on the number of bytes we attempt to access, per request.
-     */
-    this->edbgAvr8Interface->setMaximumMemoryAccessSizePerRequest(256);
-    this->setInitialised(true);
-}
-
-void XplainedPro::close() {
-    if (this->sessionStarted) {
-        this->endSession();
-    }
-
-    this->getEdbgInterface().getUsbHidInterface().close();
-    UsbDevice::close();
-}
-
-std::string XplainedPro::getSerialNumber() {
-    auto response = this->getEdbgInterface().sendAvrCommandFrameAndWaitForResponseFrame(
-        CommandFrames::Discovery::Query(CommandFrames::Discovery::QueryContext::SERIAL_NUMBER)
-    );
-
-    if (response.getResponseId() != CommandFrames::Discovery::ResponseId::OK) {
-        throw DeviceInitializationFailure(
-            "Failed to fetch serial number from device - invalid Discovery Protocol response ID."
+        auto response = this->getEdbgInterface().sendAvrCommandFrameAndWaitForResponseFrame(
+            Query(QueryContext::SERIAL_NUMBER)
         );
+
+        if (response.getResponseId() != ResponseId::OK) {
+            throw DeviceInitializationFailure(
+                "Failed to fetch serial number from device - invalid Discovery Protocol response ID."
+            );
+        }
+
+        auto data = response.getPayloadData();
+        return std::string(data.begin(), data.end());
     }
 
-    auto data = response.getPayloadData();
-    return std::string(data.begin(), data.end());
-}
+    void XplainedPro::startSession() {
+        using namespace CommandFrames::HouseKeeping;
 
-void XplainedPro::startSession() {
-    auto response = this->getEdbgInterface().sendAvrCommandFrameAndWaitForResponseFrame(
-        CommandFrames::HouseKeeping::StartSession()
-    );
+        auto response = this->getEdbgInterface().sendAvrCommandFrameAndWaitForResponseFrame(
+            StartSession()
+        );
 
-    if (response.getResponseId() == CommandFrames::HouseKeeping::ResponseId::FAILED) {
-        // Failed response returned!
-        throw DeviceInitializationFailure("Failed to start session with Xplained Pro!");
+        if (response.getResponseId() == ResponseId::FAILED) {
+            // Failed response returned!
+            throw DeviceInitializationFailure("Failed to start session with Xplained Pro!");
+        }
+
+        this->sessionStarted = true;
     }
 
-    this->sessionStarted = true;
-}
+    void XplainedPro::endSession() {
+        using namespace CommandFrames::HouseKeeping;
 
-void XplainedPro::endSession() {
-    auto response = this->getEdbgInterface().sendAvrCommandFrameAndWaitForResponseFrame(
-        CommandFrames::HouseKeeping::EndSession()
-    );
+        auto response = this->getEdbgInterface().sendAvrCommandFrameAndWaitForResponseFrame(
+            EndSession()
+        );
 
-    if (response.getResponseId() == CommandFrames::HouseKeeping::ResponseId::FAILED) {
-        // Failed response returned!
-        throw DeviceFailure("Failed to end session with Xplained Pro!");
+        if (response.getResponseId() == ResponseId::FAILED) {
+            // Failed response returned!
+            throw DeviceFailure("Failed to end session with Xplained Pro!");
+        }
+
+        this->sessionStarted = false;
     }
-
-    this->sessionStarted = false;
 }