From 500883af0c665925ddc59d5147e606950fd6621b Mon Sep 17 00:00:00 2001 From: Nav Date: Wed, 5 Jun 2024 19:33:06 +0100 Subject: [PATCH] Confirm device signature memory segment resides in the `data` address space, for UPDI targets --- .../AVR8/Services/ValidationService.php | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/build/scripts/Targets/TargetDescriptionFiles/AVR8/Services/ValidationService.php b/build/scripts/Targets/TargetDescriptionFiles/AVR8/Services/ValidationService.php index 7be36bba..90d43a65 100644 --- a/build/scripts/Targets/TargetDescriptionFiles/AVR8/Services/ValidationService.php +++ b/build/scripts/Targets/TargetDescriptionFiles/AVR8/Services/ValidationService.php @@ -172,6 +172,16 @@ class ValidationService extends \Targets\TargetDescriptionFiles\Services\Validat if (in_array(AvrPhysicalInterface::UPDI, $debugPhysicalInterfaces)) { $failures = array_merge($failures, $this->validateUpdiParameters($tdf->getUpdiParameters())); + + /* + * In Bloom's EDBG driver, we assume that the device signature memory segment resides in the 'data' + * address space, for all UPDI targets. + * + * We confirm this here. + */ + if ($tdf->getAddressSpace("data")?->getMemorySegment("signatures") === null) { + $failures[] = 'Device signature memory segment should reside in data address space'; + } } if (