doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed bug with AVR8 output pin manipulation where GPIO CLEAR registers were not being set correctly.

Browse Source 
When the GPIO CLEAR register is not the same as the SET register, there is
no need to read the value before setting the appropriate bit on the
CLEAR register. We were reading the value and *then* setting the
appropriate bit. The value we were reading had previous bits set (from previous
clear operations, I suspect), which we were not clearing (before
setting the appropriate bits). This was resulting in other GPIO pins
on the same PORT being cleared unexpectedly. Doh!
This commit is contained in:
Nav
2021-07-17 01:57:13 +01:00
parent 86134fead1
commit 41c98bc5ba
1 changed files with 32 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
src/Targets/Microchip/AVR/AVR8/Avr8.cpp
View File

@@ -447,22 +447,37 @@ void Avr8::setPinState(int variantId, const TargetPinDescriptor& pinDescriptor,
|| !padDescriptor.gpioPortClearAddress.has_value() || !padDescriptor.gpioPortClearAddress.has_value()
|| padDescriptor.gpioPortClearAddress == portSetAddress || padDescriptor.gpioPortClearAddress == portSetAddress
) { ) {
auto portSetRegisterValue = this->readMemory(TargetMemoryType::RAM, portSetAddress, 1); if (padDescriptor.gpioPortClearAddress != portSetAddress) {
/*
if (portSetRegisterValue.empty()) { * We don't need to read the register if the SET and CLEAR operations are performed via different
throw Exception("Failed to read PORT register value"); * registers.
} *
* Instead, we can just set the appropriate bit against the SET register.
auto portSetBitset = std::bitset<std::numeric_limits<unsigned char>::digits>(portSetRegisterValue.front()); */
if (portSetBitset.test(pinNumber) != (ioState == TargetPinState::IoState::HIGH)) {
// PORT set register needs updating
portSetBitset.set(pinNumber, (ioState == TargetPinState::IoState::HIGH));
this->writeMemory( this->writeMemory(
TargetMemoryType::RAM, TargetMemoryType::RAM,
portSetAddress, portSetAddress,
{static_cast<unsigned char>(portSetBitset.to_ulong())} {static_cast<unsigned char>(0x01 << pinNumber)}
); );
} else {
auto portSetRegisterValue = this->readMemory(TargetMemoryType::RAM, portSetAddress, 1);
if (portSetRegisterValue.empty()) {
throw Exception("Failed to read PORT register value");
}
auto portSetBitset = std::bitset<std::numeric_limits<unsigned char>::digits>(portSetRegisterValue.front());
if (portSetBitset.test(pinNumber) != (ioState == TargetPinState::IoState::HIGH)) {
// PORT set register needs updating
portSetBitset.set(pinNumber, (ioState == TargetPinState::IoState::HIGH));
this->writeMemory(
TargetMemoryType::RAM,
portSetAddress,
{static_cast<unsigned char>(portSetBitset.to_ulong())}
);
}
} }
} }
@@ -476,23 +491,12 @@ void Avr8::setPinState(int variantId, const TargetPinDescriptor& pinDescriptor,
) { ) {
// We also need to ensure the PORT clear register value is correct // We also need to ensure the PORT clear register value is correct
auto portClearAddress = padDescriptor.gpioPortClearAddress.value(); auto portClearAddress = padDescriptor.gpioPortClearAddress.value();
auto portClearRegisterValue = this->readMemory(TargetMemoryType::RAM, portClearAddress, 1);
if (portClearRegisterValue.empty()) { this->writeMemory(
throw Exception("Failed to read PORT (OUTSET) register value"); TargetMemoryType::RAM,
} portClearAddress,
{static_cast<unsigned char>(0x01 << pinNumber)}
auto portClearBitset = std::bitset<std::numeric_limits<unsigned char>::digits>(portClearRegisterValue.front()); );
if (portClearBitset.test(pinNumber) == (ioState == TargetPinState::IoState::LOW)) {
// PORT clear register needs updating
portClearBitset.set(pinNumber, (ioState == TargetPinState::IoState::LOW));
this->writeMemory(
TargetMemoryType::RAM,
portClearAddress,
{static_cast<unsigned char>(portClearBitset.to_ulong())}
);
}
} }
} }
} }