doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move away from using const references of std::vector<unsigned char> for target memory buffers. Replaced with std::span<const unsigned char> (via TargetMemoryBufferSpan alias)

Browse Source
This commit is contained in:
Nav
2024-11-16 21:49:49 +00:00
parent eebba986b5
commit 4147af618b
21 changed files with 39 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/TargetController/Commands/WriteTargetMemory.hpp
View File

@@ -18,18 +18,18 @@ namespace TargetController::Commands
const Targets::TargetAddressSpaceDescriptor& addressSpaceDescriptor;
const Targets::TargetMemorySegmentDescriptor& memorySegmentDescriptor;
Targets::TargetMemoryAddress startAddress;
Targets::TargetMemoryBuffer buffer;
Targets::TargetMemoryBufferSpan buffer;
WriteTargetMemory(
const Targets::TargetAddressSpaceDescriptor& addressSpaceDescriptor,
const Targets::TargetMemorySegmentDescriptor& memorySegmentDescriptor,
Targets::TargetMemoryAddress startAddress,
Targets::TargetMemoryBuffer&& buffer
Targets::TargetMemoryBufferSpan buffer
)
: addressSpaceDescriptor(addressSpaceDescriptor)
, memorySegmentDescriptor(memorySegmentDescriptor)
, startAddress(startAddress)
, buffer(std::move(buffer))
, buffer(buffer)
{};
[[nodiscard]] CommandType getType() const override {

4
src/TargetController/TargetControllerComponent.cpp
View File

@@ -741,8 +741,8 @@ namespace TargetController
void TargetControllerComponent::writeTargetMemory(
const TargetAddressSpaceDescriptor& addressSpaceDescriptor,
const TargetMemorySegmentDescriptor& memorySegmentDescriptor,
Targets::TargetMemoryAddress startAddress,
const TargetMemoryBuffer& buffer
TargetMemoryAddress startAddress,
TargetMemoryBufferSpan buffer
) {
const auto isProgramMemory = this->target->isProgramMemory(
addressSpaceDescriptor,

2
src/TargetController/TargetControllerComponent.hpp
View File

@@ -302,7 +302,7 @@ namespace TargetController
const Targets::TargetAddressSpaceDescriptor& addressSpaceDescriptor,
const Targets::TargetMemorySegmentDescriptor& memorySegmentDescriptor,
Targets::TargetMemoryAddress startAddress,
const Targets::TargetMemoryBuffer& buffer
Targets::TargetMemoryBufferSpan buffer
);
void eraseTargetMemory(