From 3c6287d694582f56996e9cb59d27a622f1ca7350 Mon Sep 17 00:00:00 2001
From: Nav <nav@navnav.me>
Date: Sun, 5 Jan 2025 23:49:31 +0000
Subject: [PATCH] Added empty register group check in TDF validation

---
 .../TargetDescriptionFiles/Services/ValidationService.php | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/build/scripts/Targets/TargetDescriptionFiles/Services/ValidationService.php b/build/scripts/Targets/TargetDescriptionFiles/Services/ValidationService.php
index 72662f69..ea31a0ba 100644
--- a/build/scripts/Targets/TargetDescriptionFiles/Services/ValidationService.php
+++ b/build/scripts/Targets/TargetDescriptionFiles/Services/ValidationService.php
@@ -471,6 +471,14 @@ class ValidationService
             $failures[] = 'Offset exceeds 32-bit unsigned integer';
         }
 
+        if (
+            empty($registerGroup->registers)
+            && empty($registerGroup->subgroups)
+            && empty($registerGroup->subgroupReferences)
+        ) {
+            $failures[] = 'Empty register group';
+        }
+
         $processedChildKeys = [];
 
         foreach ($registerGroup->registers as $register) {