From 3b0b39fe8343a20e8d27e6e9f9dc469fc41cd83c Mon Sep 17 00:00:00 2001
From: Nav <nav@navnav.me>
Date: Fri, 15 Apr 2022 22:06:38 +0100
Subject: [PATCH] Tidying

---
 .clang-tidy                                        |  1 +
 src/TargetController/TargetControllerComponent.cpp |  8 ++++++++
 src/TargetController/TargetControllerComponent.hpp |  2 +-
 src/Targets/Microchip/AVR/Fuse.hpp                 | 10 ++++++++--
 4 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/.clang-tidy b/.clang-tidy
index 782d1ce0..a39ab3a0 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -24,6 +24,7 @@ Checks: >
   -cppcoreguidelines-owning-memory,
   -cppcoreguidelines-non-private-member-variables-in-classes,
   -misc-non-private-member-variables-in-classes,
+  -bugprone-easily-swappable-parameters,
 CheckOptions:
   - key: readability-function-cognitive-complexity.DescribeBasicIncrements
     value: 1
diff --git a/src/TargetController/TargetControllerComponent.cpp b/src/TargetController/TargetControllerComponent.cpp
index fbc54a31..221cb932 100644
--- a/src/TargetController/TargetControllerComponent.cpp
+++ b/src/TargetController/TargetControllerComponent.cpp
@@ -20,6 +20,14 @@ namespace Bloom::TargetController
     using namespace Bloom::Events;
     using namespace Bloom::Exceptions;
 
+    TargetControllerComponent::TargetControllerComponent(
+        const ProjectConfig& projectConfig,
+        const EnvironmentConfig& environmentConfig
+    )
+        : projectConfig(projectConfig)
+        , environmentConfig(environmentConfig)
+    {}
+
     void TargetControllerComponent::run() {
         try {
             this->startup();
diff --git a/src/TargetController/TargetControllerComponent.hpp b/src/TargetController/TargetControllerComponent.hpp
index 68c27958..e465b780 100644
--- a/src/TargetController/TargetControllerComponent.hpp
+++ b/src/TargetController/TargetControllerComponent.hpp
@@ -37,7 +37,7 @@ namespace Bloom::TargetController
         explicit TargetControllerComponent(
             const ProjectConfig& projectConfig,
             const EnvironmentConfig& environmentConfig
-        ): projectConfig(projectConfig), environmentConfig(environmentConfig) {};
+        );
 
         /**
          * Entry point for the TargetController.
diff --git a/src/Targets/Microchip/AVR/Fuse.hpp b/src/Targets/Microchip/AVR/Fuse.hpp
index 969d752f..dddda312 100644
--- a/src/Targets/Microchip/AVR/Fuse.hpp
+++ b/src/Targets/Microchip/AVR/Fuse.hpp
@@ -16,7 +16,10 @@ namespace Bloom::Targets::Microchip::Avr
         FuseType type;
         std::uint8_t value;
 
-        Fuse(FuseType type, std::uint8_t value): type(type), value(value) {}
+        Fuse(FuseType type, std::uint8_t value)
+            : type(type)
+            , value(value)
+        {}
     };
 
     struct FuseBitsDescriptor
@@ -31,6 +34,9 @@ namespace Bloom::Targets::Microchip::Avr
          */
         std::uint8_t bitMask;
 
-        FuseBitsDescriptor(FuseType fuseType, std::uint8_t bitMask): fuseType(fuseType), bitMask(bitMask) {}
+        FuseBitsDescriptor(FuseType fuseType, std::uint8_t bitMask)
+            : fuseType(fuseType)
+            , bitMask(bitMask)
+        {}
     };
 }