doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implemented support for breakpoint caching in the GDB server

Browse Source
This commit is contained in:
Nav
2023-04-01 14:30:33 +01:00
parent 06b6c4460b
commit 3a74906541
13 changed files with 129 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/DebugServer/Gdb/CommandPackets/CommandPacket.hpp
View File

@@ -36,7 +36,13 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
class CommandPacket: public Packet
{
public:
explicit CommandPacket(const RawPacket& rawPacket): Packet(rawPacket) {}
explicit CommandPacket(const RawPacket& rawPacket)
: Packet(rawPacket)
{}
virtual bool requiresBreakpointFlush() const {
return false;
}
/**
* Should handle the command for the current active debug session.

4
src/DebugServer/Gdb/CommandPackets/ContinueExecution.hpp
View File

@@ -28,6 +28,10 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
explicit ContinueExecution(const RawPacket& rawPacket);
bool requiresBreakpointFlush() const override {
return true;
}
void handle(
DebugSession& debugSession,
Services::TargetControllerService& targetControllerService

4
src/DebugServer/Gdb/CommandPackets/Detach.hpp
View File

@@ -9,6 +9,10 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
public:
explicit Detach(const RawPacket& rawPacket);
bool requiresBreakpointFlush() const override {
return true;
}
void handle(
DebugSession& debugSession,
Services::TargetControllerService& targetControllerService

11
src/DebugServer/Gdb/CommandPackets/RemoveBreakpoint.cpp
View File

@@ -51,9 +51,18 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
}
void RemoveBreakpoint::handle(DebugSession& debugSession, TargetControllerService& targetControllerService) {
Logger::debug("Removing breakpoint at address " + std::to_string(this->address));
Logger::debug("Handling RemoveBreakpoint packet");
try {
if (debugSession.serverConfig.breakpointCachingEnabled) {
debugSession.breakpointAddressesPendingRemoval.insert(this->address);
debugSession.connection.writePacket(OkResponsePacket());
return;
}
Logger::debug("Removing breakpoint at address " + std::to_string(this->address));
targetControllerService.removeBreakpoint(TargetBreakpoint(this->address));
debugSession.connection.writePacket(OkResponsePacket());

13
src/DebugServer/Gdb/CommandPackets/SetBreakpoint.cpp
View File

@@ -54,7 +54,18 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
Logger::debug("Handling SetBreakpoint packet");
try {
targetControllerService.setBreakpoint(TargetBreakpoint(this->address));
if (
!debugSession.serverConfig.breakpointCachingEnabled
|| !debugSession.breakpointAddresses.contains(this->address)
) {
targetControllerService.setBreakpoint(TargetBreakpoint(this->address));
}
if (debugSession.serverConfig.breakpointCachingEnabled) {
debugSession.breakpointAddresses.insert(this->address);
debugSession.breakpointAddressesPendingRemoval.erase(this->address);
}
debugSession.connection.writePacket(OkResponsePacket());
} catch (const Exception& exception) {

4
src/DebugServer/Gdb/CommandPackets/StepExecution.hpp
View File

@@ -23,6 +23,10 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
explicit StepExecution(const RawPacket& rawPacket);
bool requiresBreakpointFlush() const override {
return false;
}
void handle(
DebugSession& debugSession,
Services::TargetControllerService& targetControllerService