doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removed breakpoint caching in GDB server - it's not needed!

Browse Source 
GDB can be configured to avoid needlessly updating breakpoints on the target
This commit is contained in:
Nav
2023-04-01 19:06:57 +01:00
parent b4046e8ded
commit 2d934f7ea5
12 changed files with 1 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/DebugServer/Gdb/CommandPackets/CommandPacket.hpp
View File

@@ -40,10 +40,6 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
: Packet(rawPacket)
{}
virtual bool requiresBreakpointFlush() const {
return false;
}
/**
* Should handle the command for the current active debug session.
*

4
src/DebugServer/Gdb/CommandPackets/ContinueExecution.hpp
View File

@@ -28,10 +28,6 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
explicit ContinueExecution(const RawPacket& rawPacket);
bool requiresBreakpointFlush() const override {
return true;
}
void handle(
DebugSession& debugSession,
Services::TargetControllerService& targetControllerService

4
src/DebugServer/Gdb/CommandPackets/Detach.hpp
View File

@@ -9,10 +9,6 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
public:
explicit Detach(const RawPacket& rawPacket);
bool requiresBreakpointFlush() const override {
return true;
}
void handle(
DebugSession& debugSession,
Services::TargetControllerService& targetControllerService

7
src/DebugServer/Gdb/CommandPackets/RemoveBreakpoint.cpp
View File

@@ -54,13 +54,6 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
Logger::debug("Handling RemoveBreakpoint packet");
try {
if (debugSession.serverConfig.breakpointCachingEnabled) {
debugSession.breakpointAddressesPendingRemoval.insert(this->address);
debugSession.connection.writePacket(OkResponsePacket());
return;
}
Logger::debug("Removing breakpoint at address " + std::to_string(this->address));
targetControllerService.removeBreakpoint(TargetBreakpoint(this->address));

12
src/DebugServer/Gdb/CommandPackets/SetBreakpoint.cpp
View File

@@ -54,18 +54,8 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
Logger::debug("Handling SetBreakpoint packet");
try {
if (
!debugSession.serverConfig.breakpointCachingEnabled
|| !debugSession.breakpointAddresses.contains(this->address)
) {
targetControllerService.setBreakpoint(TargetBreakpoint(this->address));
}
if (debugSession.serverConfig.breakpointCachingEnabled) {
debugSession.breakpointAddresses.insert(this->address);
debugSession.breakpointAddressesPendingRemoval.erase(this->address);
}
targetControllerService.setBreakpoint(TargetBreakpoint(this->address));
debugSession.connection.writePacket(OkResponsePacket());
} catch (const Exception& exception) {

4
src/DebugServer/Gdb/CommandPackets/StepExecution.hpp
View File

@@ -23,10 +23,6 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
explicit StepExecution(const RawPacket& rawPacket);
bool requiresBreakpointFlush() const override {
return false;
}
void handle(
DebugSession& debugSession,
Services::TargetControllerService& targetControllerService