From 27f9c1446b99d7ec45c8766a8331a545e2f0e4b9 Mon Sep 17 00:00:00 2001 From: Nav Date: Sat, 18 Mar 2023 13:00:23 +0000 Subject: [PATCH] Further reduced CPU load when hovering in the hex viewer --- .../HexViewerWidget/ItemGraphicsScene.cpp | 8 +++++--- .../HexViewerWidget/ItemGraphicsView.cpp | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.cpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.cpp index 82556fb5..5d6c486a 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.cpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsScene.cpp @@ -42,7 +42,7 @@ namespace Bloom::Widgets this->displayAbsoluteAddressAction->setCheckable(true); this->setAddressType(this->state.settings.addressLabelType); - this->setItemIndexMethod(QGraphicsScene::NoIndex); + this->setItemIndexMethod(QGraphicsScene::ItemIndexMethod::NoIndex); QObject::connect( InsightSignals::instance(), @@ -615,9 +615,10 @@ namespace Bloom::Widgets this->hoverRectX->setVisible(true); this->hoverRectY->setVisible(true); + this->hoverRectX->update(); + this->hoverRectY->update(); } - this->update(); emit this->hoveredAddress(byteItem.startAddress); } @@ -628,7 +629,8 @@ namespace Bloom::Widgets this->hoverRectX->setVisible(false); this->hoverRectY->setVisible(false); - this->update(); + this->hoverRectX->update(); + this->hoverRectY->update(); emit this->hoveredAddress(std::nullopt); } diff --git a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.cpp b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.cpp index 745d6a89..0177d1fc 100644 --- a/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.cpp +++ b/src/Insight/UserInterfaces/InsightWindow/Widgets/TargetMemoryInspectionPane/HexViewerWidget/ItemGraphicsView.cpp @@ -21,7 +21,7 @@ namespace Bloom::Widgets this->setVerticalScrollBarPolicy(Qt::ScrollBarPolicy::ScrollBarAlwaysOn); this->setHorizontalScrollBarPolicy(Qt::ScrollBarPolicy::ScrollBarAlwaysOff); this->setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::MinimumExpanding); - this->setViewportUpdateMode(QGraphicsView::NoViewportUpdate); + this->setViewportUpdateMode(QGraphicsView::ViewportUpdateMode::MinimalViewportUpdate); this->setOptimizationFlag(QGraphicsView::DontSavePainterState, true); this->setOptimizationFlag(QGraphicsView::DontAdjustForAntialiasing, true); this->setCacheMode(QGraphicsView::CacheModeFlag::CacheNone);