Tidying

src/DebugToolDrivers/Protocols/RiscVDebugSpec/DebugTranslator.hpp

@@ -78,7 +78,7 @@ namespace DebugToolDrivers::Protocols::RiscVDebugSpec
             const Targets::TargetMemorySegmentDescriptor& memorySegmentDescriptor,
             Targets::TargetMemoryAddress startAddress,
             Targets::TargetMemorySize bytes,
-            const std::set<Targets::TargetMemoryAddressRange>& excludedAddressRanges = {}
+            const std::set<Targets::TargetMemoryAddressRange>& excludedAddressRanges
         ) override;
         void writeMemory(
             const Targets::TargetAddressSpaceDescriptor& addressSpaceDescriptor,

src/DebugToolDrivers/WCH/Protocols/WchLink/WchLinkInterface.cpp

@@ -53,7 +53,7 @@ namespace DebugToolDrivers::Wch::Protocols::WchLink
         return DeviceInfo{
             WchFirmwareVersion{response.payload[0], response.payload[1]},
             response.payload.size() >= 4
-                ? std::optional{variantsById.valueAt(response.payload[2])}
+                ? variantsById.valueAt(response.payload[2])
                 : std::nullopt
         };
     }

src/DebugToolDrivers/WCH/WchLinkE/WchLinkE.cpp

@@ -11,4 +11,8 @@ namespace DebugToolDrivers::Wch
             WchLinkE::WCH_LINK_INTERFACE_NUMBER
         )
     {}
+
+    std::string WchLinkE::getName() {
+        return "WCH-LinkE";
+    }
 }

src/DebugToolDrivers/WCH/WchLinkE/WchLinkE.hpp

@@ -23,10 +23,8 @@ namespace DebugToolDrivers::Wch
         static const inline std::uint16_t USB_PRODUCT_ID = 0x8010;
         static const inline std::uint8_t WCH_LINK_INTERFACE_NUMBER = 0;
 
-        WchLinkE(const DebugToolConfig& toolConfig);
+        explicit WchLinkE(const DebugToolConfig& toolConfig);
 
-        std::string getName() override {
+        std::string getName() override;
-            return "WCH-LinkE";
-        }
     };
 }

src/Targets/RiscV/RiscV.hpp

@@ -56,7 +56,7 @@ namespace Targets::RiscV
             const TargetMemorySegmentDescriptor& memorySegmentDescriptor,
             TargetMemoryAddress startAddress,
             TargetMemorySize bytes,
-            const std::set<TargetMemoryAddressRange>& excludedAddressRanges = {}
+            const std::set<TargetMemoryAddressRange>& excludedAddressRanges
         ) override;
         void writeMemory(
             const TargetAddressSpaceDescriptor& addressSpaceDescriptor,

src/Targets/TargetMemory.hpp

@@ -105,7 +105,7 @@ namespace Targets
          *
          * @return
          */
-        std::set<Targets::TargetMemoryAddress> addresses() const noexcept {
+        [[nodiscard]] std::set<Targets::TargetMemoryAddress> addresses() const noexcept {
             auto addresses = std::set<Targets::TargetMemoryAddress>{};
             auto addressesIt = addresses.end();