From 22cca072421148bcac84fa4d3f45939140f85669 Mon Sep 17 00:00:00 2001
From: Nav <nav@navnav.me>
Date: Sat, 12 Oct 2024 16:04:55 +0100
Subject: [PATCH] Made `property-group` elements optional in TDFs

---
 .../TargetDescriptionFiles/Services/Xml/XmlService.php    | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/build/scripts/Targets/TargetDescriptionFiles/Services/Xml/XmlService.php b/build/scripts/Targets/TargetDescriptionFiles/Services/Xml/XmlService.php
index 6d55176d..b213ece5 100644
--- a/build/scripts/Targets/TargetDescriptionFiles/Services/Xml/XmlService.php
+++ b/build/scripts/Targets/TargetDescriptionFiles/Services/Xml/XmlService.php
@@ -159,9 +159,11 @@ class XmlService
             $deviceElement->setAttribute($attrName, $attrValue);
         }
 
-        $propertyGroupsElement = $document->createElement('property-groups');
-        foreach ($tdf->propertyGroups as $propertyGroup) {
-            $propertyGroupsElement->append($this->toXmlService->propertyGroupToXml($propertyGroup, $document));
+        if (!empty($tdf->propertyGroups)) {
+            $propertyGroupsElement = $document->createElement('property-groups');
+            foreach ($tdf->propertyGroups as $propertyGroup) {
+                $propertyGroupsElement->append($this->toXmlService->propertyGroupToXml($propertyGroup, $document));
+            }
         }
 
         $deviceElement->append($propertyGroupsElement);