Tidying

src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp

@@ -489,13 +489,16 @@ void EdbgAvr8Interface::configure(const TargetConfig& targetConfig) {
 
     if (!this->family.has_value()) {
         if (this->physicalInterface == PhysicalInterface::JTAG) {
-            throw InvalidConfig("Cannot use JTAG physical interface with ambiguous target name - please specify the"
+            throw InvalidConfig("The JTAG physical interface cannot be used with an ambiguous target name"
-                " exact name of the target in your configuration file. See https://bloom.oscillate.io/docs/supported-targets");
+                " - please specify the exact name of the target in your configuration file. "
+                "See https://bloom.oscillate.io/docs/supported-targets"
+            );
 
         } else if (this->physicalInterface == PhysicalInterface::UPDI) {
-            throw InvalidConfig("Cannot use UPDI physical interface with ambiguous target name - please "
+            throw InvalidConfig("The UPDI physical interface cannot be used with an ambiguous target name"
-                "specify the exact name of the target in your configuration file. "
+                " - please specify the exact name of the target in your configuration file. "
-                "See https://bloom.oscillate.io/docs/supported-targets");
+                "See https://bloom.oscillate.io/docs/supported-targets"
+            );
         }
     }
 

src/TargetController/TargetController.cpp

@@ -237,7 +237,6 @@ void TargetController::resume() {
         std::bind(&TargetController::onSetPinStateEvent, this, std::placeholders::_1)
     );
 
-    Logger::debug("TC resumed");
     this->state = TargetControllerState::ACTIVE;
     this->eventManager.triggerEvent(
         std::make_shared<TargetControllerStateReported>(this->state)

src/Targets/Microchip/AVR/AVR8/Avr8.cpp

@@ -93,8 +93,7 @@ void Avr8::loadTargetParameters() {
             auto cpuInstance = cpuPeripheralModule.instancesMappedByName.at("cpu");
 
             if (cpuInstance.registerGroupsMappedByName.contains("cpu")) {
-                auto cpuRegisterGroup = cpuInstance.registerGroupsMappedByName.at("cpu");
+                cpuRegistersOffset = cpuInstance.registerGroupsMappedByName.at("cpu").offset.value_or(0);
-                cpuRegistersOffset = cpuRegisterGroup.offset.value_or(0);
             }
         }
     }