From 1de011f948c02e07f0ed57a1ee3ec4e99299381c Mon Sep 17 00:00:00 2001 From: Nav Date: Sat, 2 Mar 2024 02:00:43 +0000 Subject: [PATCH] Correcting outdated comment and some tidying --- src/Targets/Microchip/AVR/AVR8/Avr8.cpp | 8 ++++++-- src/Targets/Microchip/AVR/AVR8/Avr8TargetConfig.hpp | 10 ++-------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/Targets/Microchip/AVR/AVR8/Avr8.cpp b/src/Targets/Microchip/AVR/AVR8/Avr8.cpp index 4fbd90d4..71d6f902 100644 --- a/src/Targets/Microchip/AVR/AVR8/Avr8.cpp +++ b/src/Targets/Microchip/AVR/AVR8/Avr8.cpp @@ -747,8 +747,12 @@ namespace Targets::Microchip::Avr::Avr8Bit ) const { return static_cast( this->fuseEnableStrategy == FuseEnableStrategy::SET - ? enabled ? (fuseByteValue | descriptor.bitMask) : fuseByteValue & ~(descriptor.bitMask) - : enabled ? fuseByteValue & ~(descriptor.bitMask) : (fuseByteValue | descriptor.bitMask) + ? enabled + ? (fuseByteValue | descriptor.bitMask) + : fuseByteValue & ~(descriptor.bitMask) + : enabled + ? fuseByteValue & ~(descriptor.bitMask) + : (fuseByteValue | descriptor.bitMask) ); } diff --git a/src/Targets/Microchip/AVR/AVR8/Avr8TargetConfig.hpp b/src/Targets/Microchip/AVR/AVR8/Avr8TargetConfig.hpp index 8ad8bd20..1b396c24 100644 --- a/src/Targets/Microchip/AVR/AVR8/Avr8TargetConfig.hpp +++ b/src/Targets/Microchip/AVR/AVR8/Avr8TargetConfig.hpp @@ -72,14 +72,8 @@ namespace Targets::Microchip::Avr::Avr8Bit * With JTAG and UPDI targets, we have to perform a full chip erase when updating the target's flash memory. * This means the user will lose their EEPROM data whenever they wish to upload any program changes via Bloom. * - * The preserveEeprom flag determines if Bloom should preserve the target's EEPROM when performing a full chip - * erase. If enabled, we'll take a backup of the target's EEPROM just before performing the chip erase, then - * restore the backup afterwards. - * - * The backup-then-restore operation can take some time to complete. This can be a source of frustration for - * users who don't care about their EEPROM data being wiped, as it can add minutes to the time it takes to - * upload program changes. This is why the function is optional - setting this flag to false will speed up - * uploads. + * The preserveEeprom flag determines if Bloom should preserve the target's EEPROM by setting the EESAVE fuse + * bit before performing the chip erase. * * This parameter is optional, and the function is enabled by default. */