This commit is contained in:
Nav
2024-11-29 01:13:18 +00:00
parent 265e60c1b7
commit 1d4def228b
2 changed files with 3 additions and 3 deletions

View File

@@ -53,7 +53,7 @@ namespace Targets::RiscV
} }
void RiscV::deactivate() { void RiscV::deactivate() {
// TODO: Is this "tidy-up" code better placed in the TC? Review after v1.1.0. // TODO: Is this "tidy-up" code better placed in the TC? Review after v2.0.0.
if (this->getExecutionState() != TargetExecutionState::STOPPED) { if (this->getExecutionState() != TargetExecutionState::STOPPED) {
this->stop(); this->stop();

View File

@@ -647,8 +647,8 @@ namespace Targets::TargetDescription
StringService::toUint32(TargetDescriptionFile::getAttribute(xmlElement, "size")), StringService::toUint32(TargetDescriptionFile::getAttribute(xmlElement, "size")),
TargetDescriptionFile::getAttribute(xmlElement, "executable") == "1", TargetDescriptionFile::getAttribute(xmlElement, "executable") == "1",
TargetMemoryAccess{ TargetMemoryAccess{
accessString.has_value() ? accessString->find('R') != std::string::npos : true, !accessString.has_value() || accessString->find('R') != std::string::npos,
accessString.has_value() ? accessString->find('W') != std::string::npos : true !accessString.has_value() || accessString->find('W') != std::string::npos
}, },
pageSize.has_value() pageSize.has_value()
? std::optional{StringService::toUint32(*pageSize)} ? std::optional{StringService::toUint32(*pageSize)}