Tidying
This commit is contained in:
@@ -8,8 +8,8 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
|
|||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
Avr8GenericResponseFrame() = default;
|
Avr8GenericResponseFrame() = default;
|
||||||
explicit Avr8GenericResponseFrame(const std::vector<AvrResponse>& AVRResponses)
|
explicit Avr8GenericResponseFrame(const std::vector<AvrResponse>& avrResponses)
|
||||||
: AvrResponseFrame(AVRResponses) {}
|
: AvrResponseFrame(avrResponses) {}
|
||||||
|
|
||||||
[[nodiscard]] unsigned char getResponseId();
|
[[nodiscard]] unsigned char getResponseId();
|
||||||
|
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
|
|||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
GetProgramCounter() = default;
|
GetProgramCounter() = default;
|
||||||
explicit GetProgramCounter(const std::vector<AvrResponse>& AVRResponses): Avr8GenericResponseFrame(AVRResponses) {}
|
explicit GetProgramCounter(const std::vector<AvrResponse>& avrResponses): Avr8GenericResponseFrame(avrResponses) {}
|
||||||
|
|
||||||
std::uint32_t extractProgramCounter() {
|
std::uint32_t extractProgramCounter() {
|
||||||
/*
|
/*
|
||||||
|
|||||||
@@ -9,7 +9,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
|
|||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
ReadMemory() = default;
|
ReadMemory() = default;
|
||||||
explicit ReadMemory(const std::vector<AvrResponse>& AVRResponses): Avr8GenericResponseFrame(AVRResponses) {}
|
explicit ReadMemory(const std::vector<AvrResponse>& avrResponses): Avr8GenericResponseFrame(avrResponses) {}
|
||||||
|
|
||||||
Targets::TargetMemoryBuffer getMemoryBuffer() {
|
Targets::TargetMemoryBuffer getMemoryBuffer() {
|
||||||
/*
|
/*
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
|
|||||||
using namespace Bloom::Exceptions;
|
using namespace Bloom::Exceptions;
|
||||||
|
|
||||||
void AvrResponseFrame::initFromAvrResponses(const std::vector<AvrResponse>& avrResponses) {
|
void AvrResponseFrame::initFromAvrResponses(const std::vector<AvrResponse>& avrResponses) {
|
||||||
// Build a raw frame buffer from the AVRResponse objects and just call initFromRawFrame()
|
// Build a raw frame buffer from the AvrResponse objects and just call initFromRawFrame()
|
||||||
std::vector<unsigned char> rawFrame;
|
std::vector<unsigned char> rawFrame;
|
||||||
|
|
||||||
for (const auto& avrResponse : avrResponses) {
|
for (const auto& avrResponse : avrResponses) {
|
||||||
|
|||||||
@@ -16,8 +16,8 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
|
|||||||
public:
|
public:
|
||||||
explicit AvrResponseFrame() = default;
|
explicit AvrResponseFrame() = default;
|
||||||
|
|
||||||
explicit AvrResponseFrame(const std::vector<AvrResponse>& AVRResponses) {
|
explicit AvrResponseFrame(const std::vector<AvrResponse>& avrResponses) {
|
||||||
this->initFromAvrResponses(AVRResponses);
|
this->initFromAvrResponses(avrResponses);
|
||||||
}
|
}
|
||||||
|
|
||||||
virtual ~AvrResponseFrame() = default;
|
virtual ~AvrResponseFrame() = default;
|
||||||
@@ -31,7 +31,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
|
|||||||
/**
|
/**
|
||||||
* An AvrResponse contains a single fragment of an AvrResponseFrame.
|
* An AvrResponse contains a single fragment of an AvrResponseFrame.
|
||||||
*
|
*
|
||||||
* This method will construct an AvrResponseFrame from a vector of AVRResponses.
|
* This method will construct an AvrResponseFrame from a vector of AvrResponse.
|
||||||
*
|
*
|
||||||
* @param avrResponses
|
* @param avrResponses
|
||||||
*/
|
*/
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
|
|||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
DiscoveryResponseFrame() = default;
|
DiscoveryResponseFrame() = default;
|
||||||
explicit DiscoveryResponseFrame(const std::vector<AvrResponse>& AVRResponses): AvrResponseFrame(AVRResponses) {}
|
explicit DiscoveryResponseFrame(const std::vector<AvrResponse>& avrResponses): AvrResponseFrame(avrResponses) {}
|
||||||
|
|
||||||
unsigned char getResponseId();
|
unsigned char getResponseId();
|
||||||
|
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
|
|||||||
{
|
{
|
||||||
public:
|
public:
|
||||||
HouseKeepingResponseFrame() = default;
|
HouseKeepingResponseFrame() = default;
|
||||||
explicit HouseKeepingResponseFrame(const std::vector<AvrResponse>& AVRResponses): AvrResponseFrame(AVRResponses) {}
|
explicit HouseKeepingResponseFrame(const std::vector<AvrResponse>& avrResponses): AvrResponseFrame(avrResponses) {}
|
||||||
|
|
||||||
unsigned char getResponseId();
|
unsigned char getResponseId();
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -52,13 +52,13 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg
|
|||||||
|
|
||||||
if (avrResponse.getFragmentCount() != fragmentCount) {
|
if (avrResponse.getFragmentCount() != fragmentCount) {
|
||||||
throw DeviceCommunicationFailure(
|
throw DeviceCommunicationFailure(
|
||||||
"Failed to fetch AVRResponse objects - invalid fragment count returned."
|
"Failed to fetch AvrResponse objects - invalid fragment count returned."
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (avrResponse.getFragmentCount() == 0 && avrResponse.getFragmentNumber() == 0) {
|
if (avrResponse.getFragmentCount() == 0 && avrResponse.getFragmentNumber() == 0) {
|
||||||
throw DeviceCommunicationFailure(
|
throw DeviceCommunicationFailure(
|
||||||
"Failed to fetch AVRResponse objects - unexpected empty response"
|
"Failed to fetch AvrResponse objects - unexpected empty response"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user