This commit is contained in:
Nav
2022-03-01 19:58:04 +00:00
parent e26af5ee7d
commit 0fba3f6d3c
8 changed files with 12 additions and 12 deletions

View File

@@ -8,8 +8,8 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
{
public:
Avr8GenericResponseFrame() = default;
explicit Avr8GenericResponseFrame(const std::vector<AvrResponse>& AVRResponses)
: AvrResponseFrame(AVRResponses) {}
explicit Avr8GenericResponseFrame(const std::vector<AvrResponse>& avrResponses)
: AvrResponseFrame(avrResponses) {}
[[nodiscard]] unsigned char getResponseId();

View File

@@ -11,7 +11,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
{
public:
GetProgramCounter() = default;
explicit GetProgramCounter(const std::vector<AvrResponse>& AVRResponses): Avr8GenericResponseFrame(AVRResponses) {}
explicit GetProgramCounter(const std::vector<AvrResponse>& avrResponses): Avr8GenericResponseFrame(avrResponses) {}
std::uint32_t extractProgramCounter() {
/*

View File

@@ -9,7 +9,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
{
public:
ReadMemory() = default;
explicit ReadMemory(const std::vector<AvrResponse>& AVRResponses): Avr8GenericResponseFrame(AVRResponses) {}
explicit ReadMemory(const std::vector<AvrResponse>& avrResponses): Avr8GenericResponseFrame(avrResponses) {}
Targets::TargetMemoryBuffer getMemoryBuffer() {
/*

View File

@@ -7,7 +7,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
using namespace Bloom::Exceptions;
void AvrResponseFrame::initFromAvrResponses(const std::vector<AvrResponse>& avrResponses) {
// Build a raw frame buffer from the AVRResponse objects and just call initFromRawFrame()
// Build a raw frame buffer from the AvrResponse objects and just call initFromRawFrame()
std::vector<unsigned char> rawFrame;
for (const auto& avrResponse : avrResponses) {

View File

@@ -16,8 +16,8 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
public:
explicit AvrResponseFrame() = default;
explicit AvrResponseFrame(const std::vector<AvrResponse>& AVRResponses) {
this->initFromAvrResponses(AVRResponses);
explicit AvrResponseFrame(const std::vector<AvrResponse>& avrResponses) {
this->initFromAvrResponses(avrResponses);
}
virtual ~AvrResponseFrame() = default;
@@ -31,7 +31,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
/**
* An AvrResponse contains a single fragment of an AvrResponseFrame.
*
* This method will construct an AvrResponseFrame from a vector of AVRResponses.
* This method will construct an AvrResponseFrame from a vector of AvrResponse.
*
* @param avrResponses
*/

View File

@@ -8,7 +8,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
{
public:
DiscoveryResponseFrame() = default;
explicit DiscoveryResponseFrame(const std::vector<AvrResponse>& AVRResponses): AvrResponseFrame(AVRResponses) {}
explicit DiscoveryResponseFrame(const std::vector<AvrResponse>& avrResponses): AvrResponseFrame(avrResponses) {}
unsigned char getResponseId();

View File

@@ -8,7 +8,7 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr::ResponseFrame
{
public:
HouseKeepingResponseFrame() = default;
explicit HouseKeepingResponseFrame(const std::vector<AvrResponse>& AVRResponses): AvrResponseFrame(AVRResponses) {}
explicit HouseKeepingResponseFrame(const std::vector<AvrResponse>& avrResponses): AvrResponseFrame(avrResponses) {}
unsigned char getResponseId();
};

View File

@@ -52,13 +52,13 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg
if (avrResponse.getFragmentCount() != fragmentCount) {
throw DeviceCommunicationFailure(
"Failed to fetch AVRResponse objects - invalid fragment count returned."
"Failed to fetch AvrResponse objects - invalid fragment count returned."
);
}
if (avrResponse.getFragmentCount() == 0 && avrResponse.getFragmentNumber() == 0) {
throw DeviceCommunicationFailure(
"Failed to fetch AVRResponse objects - unexpected empty response"
"Failed to fetch AvrResponse objects - unexpected empty response"
);
}