doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Corrected bug in AVR GDB memory access command handlers, which allowed GDB to perform out-of-bounds accesses

Browse Source
This commit is contained in:
Nav
2024-10-26 19:26:56 +01:00
parent cb8e5f1d24
commit 08af052ba9
2 changed files with 51 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/DebugServer/Gdb/AvrGdb/CommandPackets/WriteMemory.cpp
View File

@@ -45,6 +45,21 @@ namespace DebugServer::Gdb::AvrGdb::CommandPackets
auto accessibleBytes = Targets::TargetMemorySize{0};
for (const auto* memorySegmentDescriptor : memorySegmentDescriptors) {
if (
this->addressSpaceDescriptor == gdbTargetDescriptor.sramAddressSpaceDescriptor
&& memorySegmentDescriptor->type != Targets::TargetMemorySegmentType::RAM
&& memorySegmentDescriptor->type != Targets::TargetMemorySegmentType::EEPROM
&& memorySegmentDescriptor->addressRange.startAddress > gdbTargetDescriptor.sramMemorySegmentDescriptor.addressRange.endAddress
) {
/*
* Ignore this memory segment, as it resides beyond the SRAM segment and is not EEPROM, so it's
* unlikely GDB actually wanted to access it.
*
* See the comment in the ReadMemory command packet for more.
*/
continue;
}
if (!memorySegmentDescriptor->debugModeAccess.writeable) {
throw Exception{
"Attempted to access restricted memory segment (" + memorySegmentDescriptor->key