Improved naming consistency of aliases

This commit is contained in:
Nav
2022-10-01 21:01:37 +01:00
parent 2c6fd25ae4
commit 065a389dfe
56 changed files with 96 additions and 93 deletions

View File

@@ -36,7 +36,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
class CommandPacket: public Packet
{
public:
explicit CommandPacket(const RawPacketType& rawPacket): Packet(rawPacket) {}
explicit CommandPacket(const RawPacket& rawPacket): Packet(rawPacket) {}
/**
* Should handle the command for the current active debug session.

View File

@@ -12,7 +12,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using ResponsePackets::ErrorResponsePacket;
using Exceptions::Exception;
ContinueExecution::ContinueExecution(const RawPacketType& rawPacket)
ContinueExecution::ContinueExecution(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{
if (this->data.size() > 1) {

View File

@@ -26,7 +26,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
*/
std::optional<Targets::TargetProgramCounter> fromProgramCounter;
explicit ContinueExecution(const RawPacketType& rawPacket);
explicit ContinueExecution(const RawPacket& rawPacket);
void handle(
DebugSession& debugSession,

View File

@@ -16,7 +16,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using Exceptions::Exception;
Detach::Detach(const RawPacketType& rawPacket)
Detach::Detach(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{}

View File

@@ -7,7 +7,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
class Detach: public CommandPacket
{
public:
explicit Detach(const RawPacketType& rawPacket);
explicit Detach(const RawPacket& rawPacket);
void handle(
DebugSession& debugSession,

View File

@@ -15,7 +15,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
class InterruptExecution: public CommandPacket
{
public:
explicit InterruptExecution(const RawPacketType& rawPacket): CommandPacket(rawPacket) {}
explicit InterruptExecution(const RawPacket& rawPacket): CommandPacket(rawPacket) {}
void handle(
DebugSession& debugSession,

View File

@@ -10,7 +10,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using ResponsePackets::EmptyResponsePacket;
Monitor::Monitor(const RawPacketType& rawPacket)
Monitor::Monitor(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{
if (this->data.size() > 6) {

View File

@@ -17,7 +17,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
*/
std::string command;
explicit Monitor(const RawPacketType& rawPacket);
explicit Monitor(const RawPacket& rawPacket);
void handle(
DebugSession& debugSession,

View File

@@ -19,7 +19,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using Exceptions::Exception;
ReadRegisters::ReadRegisters(const RawPacketType& rawPacket)
ReadRegisters::ReadRegisters(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{
if (this->data.size() >= 2 && this->data.front() == 'p') {

View File

@@ -23,9 +23,9 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
* If the register number is not supplied (as is the case with "g" packets), the server is expected to respond
* with values for all registers.
*/
std::optional<GdbRegisterNumberType> registerNumber;
std::optional<GdbRegisterNumber> registerNumber;
explicit ReadRegisters(const RawPacketType& rawPacket);
explicit ReadRegisters(const RawPacket& rawPacket);
void handle(
DebugSession& debugSession,

View File

@@ -21,7 +21,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using Exceptions::Exception;
RemoveBreakpoint::RemoveBreakpoint(const RawPacketType& rawPacket)
RemoveBreakpoint::RemoveBreakpoint(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{
if (this->data.size() < 6) {

View File

@@ -28,7 +28,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
*/
Targets::TargetMemoryAddress address = 0;
explicit RemoveBreakpoint(const RawPacketType& rawPacket);
explicit RemoveBreakpoint(const RawPacket& rawPacket);
void handle(
DebugSession& debugSession,

View File

@@ -21,7 +21,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using Exceptions::Exception;
SetBreakpoint::SetBreakpoint(const RawPacketType& rawPacket)
SetBreakpoint::SetBreakpoint(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{
if (this->data.size() < 6) {

View File

@@ -28,7 +28,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
*/
Targets::TargetMemoryAddress address = 0;
explicit SetBreakpoint(const RawPacketType& rawPacket);
explicit SetBreakpoint(const RawPacket& rawPacket);
void handle(
DebugSession& debugSession,

View File

@@ -13,7 +13,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using Exceptions::Exception;
StepExecution::StepExecution(const RawPacketType& rawPacket)
StepExecution::StepExecution(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{
if (this->data.size() > 1) {

View File

@@ -21,7 +21,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
*/
std::optional<Targets::TargetProgramCounter> fromProgramCounter;
explicit StepExecution(const RawPacketType& rawPacket);
explicit StepExecution(const RawPacket& rawPacket);
void handle(
DebugSession& debugSession,

View File

@@ -21,7 +21,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using Bloom::Exceptions::Exception;
using Gdb::Exceptions::ClientNotSupported;
SupportedFeaturesQuery::SupportedFeaturesQuery(const RawPacketType& rawPacket)
SupportedFeaturesQuery::SupportedFeaturesQuery(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{
/*

View File

@@ -22,7 +22,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
class SupportedFeaturesQuery: public CommandPacket
{
public:
explicit SupportedFeaturesQuery(const RawPacketType& rawPacket);
explicit SupportedFeaturesQuery(const RawPacket& rawPacket);
[[nodiscard]] bool isFeatureSupported(const Feature& feature) const {
return this->supportedFeatures.find(feature) != this->supportedFeatures.end();

View File

@@ -22,7 +22,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
using Exceptions::Exception;
WriteRegister::WriteRegister(const RawPacketType& rawPacket)
WriteRegister::WriteRegister(const RawPacket& rawPacket)
: CommandPacket(rawPacket)
{
// The P packet updates a single register

View File

@@ -17,7 +17,7 @@ namespace Bloom::DebugServer::Gdb::CommandPackets
int registerNumber = 0;
std::vector<unsigned char> registerValue;
explicit WriteRegister(const RawPacketType& rawPacket);
explicit WriteRegister(const RawPacket& rawPacket);
void handle(
DebugSession& debugSession,