doryan/BloomPatched
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

When range stepping, start with a single step, as expected by GDB

Browse Source
This commit is contained in:
Nav
2023-09-11 16:56:37 +01:00
parent 7d4ce1050f
commit 008f5bb62e
3 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/DebugServer/Gdb/AvrGdb/CommandPackets/VContRangeStep.cpp
View File

@@ -205,7 +205,16 @@ namespace DebugServer::Gdb::AvrGdb::CommandPackets
}
debugSession.startRangeSteppingSession(std::move(rangeSteppingSession), targetControllerService);
targetControllerService.continueTargetExecution(std::nullopt, std::nullopt);
/*
* GDB expects us to start the range stepping session with a single step, and then only continue if the
* single step didn't immediately take us out of the stepping range.
*
* So we kick off a single step here, then let AvrGdbRsp::handleTargetStoppedGdbResponse() determine if
* we should continue. See that member function for more.
*/
debugSession.activeRangeSteppingSession->singleStepping = true;
targetControllerService.stepTargetExecution(std::nullopt);
debugSession.waitingForBreak = true;
} catch (const Exception& exception) {